Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint errors #39397

Merged

Conversation

allenkim0129
Copy link
Contributor

@allenkim0129 allenkim0129 commented Jan 24, 2025

Description

Pylint was causing PR build failures. This Fix will fix the pylint errors.
The majority of the errors were caused by response_hook parameter. response_hook parameter was added to docstrings for number of functions, but none of them were added to the definition of the functions. This caused the docstring and the function definition to be out of sync.

The main updates:

  1. If the response_hook parameter was used inside of the functions, I added the parameter to the function definition.
  2. If parameter types were mismatching, I updated the parameter types and docstrings.
  3. Some pylint checks were unable to be addressed at this time, so I disabled those checks: (do-not-import-asyncio, do-not-log-exceptions, docstring-keyword-should-match-keyword-only)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@allenkim0129 allenkim0129 marked this pull request as ready for review January 25, 2025 00:19
@allenkim0129 allenkim0129 requested review from annatisch and a team as code owners January 25, 2025 00:19
@allenkim0129 allenkim0129 changed the title Fix pylint errors Fix pylint errors + Remove unnecessary params in APIs Jan 29, 2025
@allenkim0129 allenkim0129 changed the title Fix pylint errors + Remove unnecessary params in APIs Fix pylint errors Jan 29, 2025
@allenkim0129 allenkim0129 merged commit 19de891 into Azure:main Feb 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants