-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pylint errors #39397
Merged
allenkim0129
merged 14 commits into
Azure:main
from
allenkim0129:users/allekim/fix/next-pylint-error
Feb 27, 2025
Merged
Fix pylint errors #39397
allenkim0129
merged 14 commits into
Azure:main
from
allenkim0129:users/allekim/fix/next-pylint-error
Feb 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
l0lawrence
reviewed
Jan 25, 2025
sdk/cosmos/azure-cosmos/azure/cosmos/_change_feed/change_feed_utils.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/_change_feed/change_feed_utils.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/aio/_cosmos_client_connection_async.py
Show resolved
Hide resolved
l0lawrence
reviewed
Jan 27, 2025
sdk/cosmos/azure-cosmos/azure/cosmos/_change_feed/change_feed_utils.py
Outdated
Show resolved
Hide resolved
l0lawrence
reviewed
Jan 27, 2025
sdk/cosmos/azure-cosmos/azure/cosmos/_change_feed/change_feed_utils.py
Outdated
Show resolved
Hide resolved
l0lawrence
reviewed
Jan 27, 2025
This was referenced Jan 27, 2025
l0lawrence
reviewed
Jan 30, 2025
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py
Outdated
Show resolved
Hide resolved
l0lawrence
reviewed
Feb 11, 2025
l0lawrence
approved these changes
Feb 12, 2025
annatisch
reviewed
Feb 26, 2025
sdk/cosmos/azure-cosmos/azure/cosmos/_change_feed/change_feed_utils.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py
Outdated
Show resolved
Hide resolved
annatisch
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pylint was causing PR build failures. This Fix will fix the pylint errors.
The majority of the errors were caused by
response_hook
parameter.response_hook
parameter was added to docstrings for number of functions, but none of them were added to the definition of the functions. This caused the docstring and the function definition to be out of sync.The main updates:
response_hook
parameter was used inside of the functions, I added the parameter to the function definition.do-not-import-asyncio
,do-not-log-exceptions
,docstring-keyword-should-match-keyword-only
)All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines