-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip some pylint testing #39418
Skip some pylint testing #39418
Conversation
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unblocking -- #39397 (review) will fix these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @allenkim0129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
Github issue for follow-up tasks: #39423 |
Description
The pylint tests were blocking SDK releases, but the issue was only related with the docstrings not actual code functionalities.
Since the test failures are blocking our breaking fix releases, we wanted to skip this for now and fix the pylint fix to a seperate PR.
The PR for the actual fix has been created already and will be reviewed and go through API and architect approval process.
PR: #39397
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines