Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some pylint testing #39418

Conversation

allenkim0129
Copy link
Contributor

@allenkim0129 allenkim0129 commented Jan 27, 2025

Description

The pylint tests were blocking SDK releases, but the issue was only related with the docstrings not actual code functionalities.

Since the test failures are blocking our breaking fix releases, we wanted to skip this for now and fix the pylint fix to a seperate PR.

The PR for the actual fix has been created already and will be reviewed and go through API and architect approval process.
PR: #39397

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@allenkim0129 allenkim0129 marked this pull request as ready for review January 27, 2025 19:43
@allenkim0129 allenkim0129 requested review from annatisch and a team as code owners January 27, 2025 19:43
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@l0lawrence l0lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblocking -- #39397 (review) will fix these

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @allenkim0129

Copy link
Member

@bambriz bambriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@allenkim0129
Copy link
Contributor Author

Github issue for follow-up tasks: #39423

@allenkim0129 allenkim0129 merged commit 18a2746 into Azure:main Jan 27, 2025
23 checks passed
@allenkim0129 allenkim0129 deleted the users/allekim/fix/disable-next-pylint-error branch January 27, 2025 21:31
allenkim0129 added a commit to allenkim0129/azure-sdk-for-python that referenced this pull request Jan 27, 2025
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants