Skip to content

Revert "feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD" #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Revert "feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD" #3949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ead493
Initial plan
Copilot Aug 19, 2025
6998ab8
Remove AppGatewaySubnetGUID field from OverlayExtensionConfig CRD
Copilot Aug 19, 2025
6f03d7f
Updated Docker base images
nairashu Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cni/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ARG OS_VERSION
ARG OS

# mcr.microsoft.com/oss/go/microsoft/golang:1.23-azurelinux3.0
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:52da06982153e87569d588c8d25dc519903e92f740fc0d7770f38dfd9f7bb0f2 AS go
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:2ee838d78b546ea43bec72051656ef74c98e6ae17f55be4fb45bd5d9add6dddf AS go

# mcr.microsoft.com/azurelinux/base/core:3.0
FROM --platform=linux/${ARCH} mcr.microsoft.com/azurelinux/base/core@sha256:e9bb4e5a79123f2ae29dc601f68adf63a636a455c4259423712b06b798cb201e AS mariner-core
Expand Down
2 changes: 1 addition & 1 deletion cns/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ARG OS_VERSION
ARG OS

# mcr.microsoft.com/oss/go/microsoft/golang:1.23-azurelinux3.0
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:52da06982153e87569d588c8d25dc519903e92f740fc0d7770f38dfd9f7bb0f2 AS go
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:2ee838d78b546ea43bec72051656ef74c98e6ae17f55be4fb45bd5d9add6dddf AS go

# mcr.microsoft.com/azurelinux/base/core:3.0
FROM mcr.microsoft.com/azurelinux/base/core@sha256:e9bb4e5a79123f2ae29dc601f68adf63a636a455c4259423712b06b798cb201e AS mariner-core
Expand Down
5 changes: 0 additions & 5 deletions crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ type OverlayExtensionConfigSpec struct {
// +kubebuilder:validation:MaxLength=43
// 43 is max length of IPv6 CIDR string
ExtensionIPRange string `json:"extensionIPRange,omitempty"`

// AppGatewaySubnetGUID field defines a subnet delegated to Application Gateway that should be able to reach routing domain ip addresses. This needs to be a valid GUID.
// +kubebuilder:validation:Optional
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
AppGatewaySubnetGUID string `json:"appGatewaySubnetGUID,omitempty"`
}

type OECState string
Expand Down
8 changes: 0 additions & 8 deletions crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ spec:
spec:
description: OverlayExtensionConfigSpec defines the desired state of OverlayExtensionConfig.
properties:
appGatewaySubnetGUID:
description: AppGatewaySubnetGUID field defines a subnet delegated
to Application Gateway that should be able to reach routing domain
ip addresses. This needs to be a valid GUID.
type: string
x-kubernetes-validations:
- message: Value is immutable
rule: self == oldSelf
extensionIPRange:
description: |-
ExtensionIPRange field defines a CIDR that should be able to reach routing domain ip addresses.
Expand Down
Loading