Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 19, 2025

This PR reverts the changes made in PR #3925 which added the App Gateway Subnet ID field to the OverlayExtensionConfig CRD.

Changes Reverted

The following field has been removed from the OverlayExtensionConfigSpec:

// AppGatewaySubnetGUID field defines a subnet delegated to Application Gateway that should be able to reach routing domain ip addresses. This needs to be a valid GUID.
// +kubebuilder:validation:Optional
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
AppGatewaySubnetGUID string `json:"appGatewaySubnetGUID,omitempty"`

Files Modified

  1. crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go

    • Removed the AppGatewaySubnetGUID field and its associated kubebuilder validation annotations
  2. crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml

    • Regenerated CRD manifest with the field removed from the OpenAPI schema

Testing

  • All existing tests continue to pass
  • CRD package builds successfully
  • No references to the removed field remain in the codebase
  • Generated manifests are consistent with the Go struct definition

The OverlayExtensionConfig CRD is now restored to its state before PR #3925, containing only the original ExtensionIPRange field in the spec.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Revert "feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD" Revert "feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD" Aug 19, 2025
@Copilot Copilot AI requested a review from nairashu August 19, 2025 21:15
Copilot finished work on behalf of nairashu August 19, 2025 21:15
@nairashu nairashu marked this pull request as ready for review August 19, 2025 21:28
@Copilot Copilot AI review requested due to automatic review settings August 19, 2025 21:28
@nairashu nairashu requested a review from a team as a code owner August 19, 2025 21:28
@nairashu nairashu requested a review from BeegiiK August 19, 2025 21:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes from PR #3925 that added an App Gateway Subnet ID field to the OverlayExtensionConfig Custom Resource Definition (CRD). The revert removes the AppGatewaySubnetGUID field and its associated validation annotations.

  • Removes the AppGatewaySubnetGUID field from the OverlayExtensionConfigSpec struct
  • Eliminates kubebuilder validation annotations for the removed field
  • Regenerates the CRD manifest to reflect the structural changes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go Removes AppGatewaySubnetGUID field and validation annotations from Go struct
crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml Updates generated CRD manifest to remove appGatewaySubnetGUID property from OpenAPI schema

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nairashu nairashu enabled auto-merge September 2, 2025 17:19
rbtr
rbtr previously approved these changes Sep 2, 2025
rejain456
rejain456 previously approved these changes Sep 2, 2025
@nairashu nairashu dismissed stale reviews from rejain456 and rbtr via 6f03d7f September 2, 2025 17:44
@nairashu nairashu requested review from a team as code owners September 2, 2025 17:44
@nairashu
Copy link
Contributor

nairashu commented Sep 2, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nairashu nairashu added this pull request to the merge queue Sep 2, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 2, 2025
…ension Config CRD" (#3949)

* Initial plan

* Remove AppGatewaySubnetGUID field from OverlayExtensionConfig CRD

Co-authored-by: nairashu <[email protected]>

* Updated Docker base images

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: nairashu <[email protected]>
Co-authored-by: Ashish Nair <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants