-
Notifications
You must be signed in to change notification settings - Fork 256
Revert "feat: Add App Gateway Subnet ID as a field to the Overlay Extension Config CRD" #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: nairashu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts changes from PR #3925 that added an App Gateway Subnet ID field to the OverlayExtensionConfig Custom Resource Definition (CRD). The revert removes the AppGatewaySubnetGUID
field and its associated validation annotations.
- Removes the
AppGatewaySubnetGUID
field from the OverlayExtensionConfigSpec struct - Eliminates kubebuilder validation annotations for the removed field
- Regenerates the CRD manifest to reflect the structural changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go | Removes AppGatewaySubnetGUID field and validation annotations from Go struct |
crd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml | Updates generated CRD manifest to remove appGatewaySubnetGUID property from OpenAPI schema |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
…ension Config CRD" (#3949) * Initial plan * Remove AppGatewaySubnetGUID field from OverlayExtensionConfig CRD Co-authored-by: nairashu <[email protected]> * Updated Docker base images --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: nairashu <[email protected]> Co-authored-by: Ashish Nair <[email protected]>
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This PR reverts the changes made in PR #3925 which added the App Gateway Subnet ID field to the OverlayExtensionConfig CRD.
Changes Reverted
The following field has been removed from the
OverlayExtensionConfigSpec
:Files Modified
crd/overlayextensionconfig/api/v1alpha1/overlayextensionconfig_types.go
AppGatewaySubnetGUID
field and its associated kubebuilder validation annotationscrd/overlayextensionconfig/manifests/acn.azure.com_overlayextensionconfigs.yaml
Testing
The OverlayExtensionConfig CRD is now restored to its state before PR #3925, containing only the original
ExtensionIPRange
field in the spec.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.