Make the top views of the QE be reused by the scopes #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
the
[Feature] Gravatar-Quickeditor
AdamGrzybkowski
force-pushed
the
adam/GRA-24
branch
from
0fe1e08 to
38b526a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the editor UI to consolidate shared views into a new QuickEditor composable and moves profile fetching logic into QuickEditorViewModel.
- Introduces QuickEditorViewModel and QuickEditor composable for shared header UI.
- Removes redundant profile-related state and clock-based cache busting from AvatarPicker and its tests.
- Adjusts layout, such as repositioning the alert banner, to consolidate the editor scopes.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| QuickEditorViewModelTest.kt | Tests updated for QuickEditorViewModel profile fetching and avatar cache refresh. |
| QuickEditorTest.kt | Screenshot tests verify unchanged UI appearance except for alert banner placement. |
| AvatarPickerViewModelTest.kt | Removes profile fetching tests and avatarCacheBuster expectations consistent with separation of concerns. |
| AvatarPickerTest.kt | Removes profile-related properties in preview, reflecting new design. |
| QuickEditorViewModel.kt, QuickEditorUiState.kt, QuickEditorEvent.kt, QuickEditor.kt | New implementation for the consolidated QuickEditor component and its supporting ViewModel, state and events. |
| GravatarQuickEditorPage.kt | Updates navigation graph to use QuickEditor instead of AvatarPicker for the editor graph. |
| AvatarPickerViewModel.kt, AvatarPickerUiState.kt, AvatarPicker.kt | Adjustments to remove outdated profile handling and clock updates in the AvatarPicker portion. |
Comments suppressed due to low confidence (1)
gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/editor/GravatarQuickEditorPage.kt:158
- The insertion of "it.viewModelStore" appears out-of-place and does not seem to be used in a meaningful way. Please verify whether this was intended or remove it if unnecessary.
it.viewModelStore
38b526a to
36640b6
Compare
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
force-pushed
the
adam/GRA-24
branch
from
36640b6 to
2dc72c5
Compare
etoledom
reviewed
Apr 28, 2025
| internal fun QuickEditor( | ||
| gravatarQuickEditorParams: GravatarQuickEditorParams, | ||
| handleExpiredSession: Boolean, | ||
| onAvatarSelected: () -> Unit, |
There was a problem hiding this comment.
One thing we decided to do on iOS is to have a general update() callback (we call it updateHandler(), and it has a parameter with the information of which kind of update it is.
Maybe is not needed yet but it will possible become handy when we start to implement the About Info editor.
There was a problem hiding this comment.
Thanks! The API design is yet to be decided on, so I will definitely look at iOS.
etoledom
approved these changes
Apr 28, 2025
Base automatically changed from
adam/GRA-25_picker
to
feature/quick_editor_about_info
April 29, 2025 07:58
…tion That the component that will also be responsible for the Profile card - displaying the user info, refreshing and showing possible navigation options
AdamGrzybkowski
force-pushed
the
adam/GRA-24
branch
from
f97dfb6 to
d8d050c
Compare
AdamGrzybkowski
merged commit ed14233
into
feature/quick_editor_about_info
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
QuickEditorcomposable component that will host the shared UI (top bar, email, and the profile card) and different editor scopes ascontentthat will be added in the next PRs.Some of the logic from the
AvatarPickerViewModelwas now moved to the newQuickEditorViewModelas the profile fetching will only happen there (plus some extra logic to force refresh the avatar).Additionally, the alert banner that's shown the no avatar is selected was moved below the profile card, so that it stays in the avatar picker content space. Apart from this, there should be no UI change.
Testing Steps
As mentioned above, the UI should be unchanged (except for the alert banner position) but there are a few things worth testing:
Avatar updates in the profile card
Make sure the avatar is properly updated after each of the below:
Refreshing after network failure