Skip to content

Commit 0fe1e08

Browse files
Add/adjust test for the new component
1 parent 793a5ef commit 0fe1e08

8 files changed

+213
-216
lines changed

gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/editor/QuickEditor.kt

+17-14
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package com.gravatar.quickeditor.ui.editor
33
import androidx.compose.foundation.layout.Column
44
import androidx.compose.foundation.layout.fillMaxWidth
55
import androidx.compose.foundation.layout.padding
6+
import androidx.compose.material3.Surface
67
import androidx.compose.runtime.Composable
78
import androidx.compose.runtime.collectAsState
89
import androidx.compose.runtime.getValue
@@ -56,20 +57,22 @@ internal fun QuickEditor(
5657
QEPageDefault(
5758
onDoneClicked = onDoneClicked,
5859
content = {
59-
Column {
60-
EmailLabel(
61-
email = uiState.email,
62-
modifier = Modifier
63-
.fillMaxWidth()
64-
.padding(bottom = 10.dp),
65-
)
66-
ProfileCard(
67-
profile = uiState.profile,
68-
email = uiState.email,
69-
avatarCacheBuster = uiState.avatarCacheBuster.toString(),
70-
modifier = Modifier.padding(start = 16.dp, end = 16.dp, bottom = 16.dp),
71-
)
72-
content()
60+
Surface {
61+
Column {
62+
EmailLabel(
63+
email = uiState.email,
64+
modifier = Modifier
65+
.fillMaxWidth()
66+
.padding(bottom = 10.dp),
67+
)
68+
ProfileCard(
69+
profile = uiState.profile,
70+
email = uiState.email,
71+
avatarCacheBuster = uiState.avatarCacheBuster.toString(),
72+
modifier = Modifier.padding(start = 16.dp, end = 16.dp, bottom = 16.dp),
73+
)
74+
content()
75+
}
7376
}
7477
},
7578
)

gravatar-quickeditor/src/test/java/com/gravatar/quickeditor/ui/avatarpicker/AvatarPickerTest.kt

-10
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,19 @@
11
package com.gravatar.quickeditor.ui.avatarpicker
22

3-
import com.gravatar.extensions.defaultProfile
43
import com.gravatar.quickeditor.ui.editor.AvatarPickerContentLayout
54
import com.gravatar.quickeditor.ui.gravatarScreenshotTest
65
import com.gravatar.restapi.models.Avatar
76
import com.gravatar.types.Email
8-
import com.gravatar.ui.components.ComponentState
97
import com.gravatar.uitestutils.RoborazziTest
108
import org.junit.Test
119
import org.robolectric.annotation.Config
1210
import java.net.URI
1311

1412
class AvatarPickerTest : RoborazziTest() {
15-
private val profile = defaultProfile(
16-
hash = "hash",
17-
displayName = "Henry Wong",
18-
location = "London, UK",
19-
)
20-
2113
@Test
2214
fun avatarPickerListLoaded() = gravatarScreenshotTest {
2315
AvatarPicker(
2416
uiState = AvatarPickerUiState(
25-
profile = ComponentState.Loaded(profile),
2617
email = Email("[email protected]"),
2718
avatarPickerContentLayout = AvatarPickerContentLayout.Horizontal,
2819
emailAvatars = EmailAvatars(
@@ -54,7 +45,6 @@ class AvatarPickerTest : RoborazziTest() {
5445
fun avatarPickerListLoadedDark() = gravatarScreenshotTest {
5546
AvatarPicker(
5647
uiState = AvatarPickerUiState(
57-
profile = ComponentState.Loaded(profile),
5848
email = Email("[email protected]"),
5949
avatarPickerContentLayout = AvatarPickerContentLayout.Horizontal,
6050
emailAvatars = EmailAvatars(

0 commit comments

Comments
 (0)