-
Notifications
You must be signed in to change notification settings - Fork 32
Add gravatarImageUrlToGravatarImageUrl to utils + minor improvements #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c42facf
Rename _mystery man_ to _mystery person_ like on the official docs ht…
maxme 84e76db
Swap size/default image parameters same order as in wpandroid
maxme dd41e97
Fix #37: add missing robohash to the list of default image avatar
maxme 33407b9
- Add new utiltiy functions gravatarImageUrlToGravatarImageUrl and gr…
maxme 2d6c782
Fix one big mistake, rename _size_ query param to _s_
maxme a09a35e
Make sure size parameters is in between 1..2048
maxme 5c2dd8b
Rename test functions
maxme bdaca8e
Reuse the same host as the original in gravatarImageUrlToGravatarImag…
maxme bae35de
Moves GravatarUtils tests to the same file and fix string formatting
maxme 2eb0adc
Rename gravatarImageUrlToGravatarImageUri to rewriteGravatarUriQueryP…
maxme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
package com.gravatar | ||
|
||
enum class DefaultAvatarImage(val style: String) { | ||
MYSTERY_MAN("mm"), | ||
MYSTERY_PERSON("mp"), | ||
STATUS_404("404"), | ||
IDENTICON("identicon"), | ||
MONSTER("monsterid"), | ||
WAVATAR("wavatar"), | ||
RETRO("retro"), | ||
BLANK("blank"), | ||
ROBOHASH("robohash"), | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package com.gravatar | ||
|
||
enum class ImageRating(val rating: String) { | ||
General("g"), | ||
ParentalGuidance("pg"), | ||
Restricted("r"), | ||
X("x"), | ||
} |
65 changes: 0 additions & 65 deletions
65
gravatar/src/test/java/com/gravatar/GravatarUtilsRobolectricTest.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.