-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gravatarImageUrlToGravatarImageUrl to utils + minor improvements #38
Conversation
3927fa5
to
55ad795
Compare
Note: I'm open to suggestions to rename
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Nice work @maxme! I love the amount of unit tests you added.
I left some comments, but they are all non-blocking.
gravatar/src/test/java/com/gravatar/GravatarUtilsRobolectricTest.kt
Outdated
Show resolved
Hide resolved
a0fb760
to
fc91874
Compare
@hamorillo, it should be good to go as I integrated all your comments, but better do a second pass. |
…avatarImageUrlToGravatarImageUri to rewrite existing gravatar urls - Fix #36: add more options to gravatarImageUrlToGravatarImageUrl and emailAddressToGravatarUrl
fc91874
to
2eb0adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Great job! 🚀
Main goal of this PR is to add a new
gravatarImageUrlToGravatarImageUrl
function.Why adding this function here? Well, I think this can be a common pattern for other developers, not just for WordPress:
STATUS_404
default image might be a great use).When we start writing documentation, we should provide examples of this one, but I'm not sure we should push for it.
This PR also: