Skip to content

adds quiescence_period_refractory_duration generator and curriculum - #155

Merged
micahwoodard merged 2 commits into
mainfrom
feat-add-iti-refractory-in-curriculum
Aug 25, 2026
Merged

adds quiescence_period_refractory_duration generator and curriculum#155
micahwoodard merged 2 commits into
mainfrom
feat-add-iti-refractory-in-curriculum

Conversation

@micahwoodard

@micahwoodard micahwoodard commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Adds quiescence_period_refractory_duration to block based spec and adds to curriculum. Addresses #165

@bruno-f-cruz bruno-f-cruz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a stupid question, but cant you just abstract this out since from what @alexpiet said this should be the same as the ITI (which is already being defined in the generator?)?

@micahwoodard

Copy link
Copy Markdown
Collaborator Author

@bruno-f-cruz I could. I thought it would be better to expose it directly in case any one wants the option for it to be different than the iti in the future. Unlikely but now a possibility without too much overhead

@bruno-f-cruz

Copy link
Copy Markdown
Member

Given this is how it was explained by Alex I would hide that implementation detail to make it easier for people to reason about it. But I don't disagree w you about future proofing :p

@micahwoodard

Copy link
Copy Markdown
Collaborator Author

Switched to using iti distribution for refractory period and also fixed some discrepant values between v1 and v2 curriculums

@micahwoodard

Copy link
Copy Markdown
Collaborator Author

When quiescence is defined, it doesn't look like the distribution is being resampled. Here are the values with the given distribution. No error now tho :)
image

@bruno-f-cruz

Copy link
Copy Markdown
Member

Sorry, I was using the wrong type overload for the RNG and always using the same seed. Try now.

@micahwoodard
micahwoodard changed the base branch from feature-implement-iti-refactory-period-during-quiescence to main August 25, 2026 16:45
@micahwoodard
micahwoodard merged commit 426fb13 into main Aug 25, 2026
4 checks passed
@micahwoodard
micahwoodard deleted the feat-add-iti-refractory-in-curriculum branch August 25, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants