Implement refractory period during quiescence - #153
Merged
micahwoodard merged 4 commits intoAug 25, 2026
Conversation
micahwoodard
approved these changes
Aug 20, 2026
alexpiet
approved these changes
Aug 20, 2026
micahwoodard
self-requested a review
August 21, 2026 19:11
Collaborator
|
@bruno-f-cruz tested on rig and when there is a lick in quiescent period, trial stalls forever in the quiescent period if quiescent_period_refractory_duration is none and get this error if defined |
Collaborator
|
@bruno-f-cruz still seeing the behavior of infinite quiescent period if refractory time is none |
Collaborator
|
@bruno-f-cruz tested on rig and appears to be working as intended. |
micahwoodard
deleted the
feature-implement-iti-refactory-period-during-quiescence
branch
August 25, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently rather awkward behavior since I am not sure how the quick retract interacts with this logic. I left it decoupled, and all delays are independently set, but we may want to rethink this in the future and lock the retraction to the duration of the refractory period (iti duration). Not sure.