-
Notifications
You must be signed in to change notification settings - Fork 1
[Proposal] Revised OME-Zarr data type hierarchy and interface #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Jarbuckle
wants to merge
108
commits into
main
Choose a base branch
from
joel/override-existing-rendering-pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quested multiple times
…endering'" This reverts commit 58f8eb7.
Jarbuckle
commented
Oct 15, 2025
Comment on lines
291
to
314
/** | ||
* HEY!!! | ||
* this is an example React Component for rendering A single slice of an OMEZARR image in a react component | ||
* This example is as bare-bones as possible! It is NOT the recommended way to do anything, its just trying to show | ||
* one way of: | ||
* 1. using our rendering utilities for OmeZarr data, specifically in a react component. Your needs for state-management, | ||
* slicing logic, etc might all be different! | ||
* | ||
*/ | ||
function DataPlease() { | ||
// load our canned data for now: | ||
const [omezarr, setfile] = useState<OmeZarrMetadata | undefined>(undefined); | ||
useEffect(() => { | ||
loadMetadata(demoOptions[0].res).then((dataset) => { | ||
setfile(dataset); | ||
logger.info('loaded!'); | ||
}); | ||
}, []); | ||
return ( | ||
<RenderServerProvider> | ||
<SliceView omezarr={omezarr} /> | ||
</RenderServerProvider> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to its own file, basic-omezarr-demo.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Proposal] Revised OME-Zarr data type hierarchy and interface
What
Detailed discussion here:
In brief, this is a proposed new data type hierarchy and loading/access interface for OME-Zarr data. Its primary characteristics:
OmeZarrConnection
OmeZarrFileset
OmeZarrLevel
PR Checklist
main
?