-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Husky and lint staged #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a trivial spacing change on this file to see if it would run it on the staged file and it did!! Woooo!
So I disable husky pre-hook stuff locally - it does not play nice with git on windows. I'm agreeable to adding this, but I'd really really like to remove some (most?) of these lint rules. |
Sorry, could've made the intent here clearer. This is to auto-fix any fixable rules or formatting on commit, not to block commits if they fail a check. Also I need to verify it's working how I expect! I forgot to test if it allows you to successfully commit with a linting error in the code. |
Shoot, it does prevent commits if there are errors. Will look into this again later! |
chore: Husky and lint staged
What
Add pre-commit hooks to run the biome fixes that can be done
How
Add
hucky
Add
lint-staged
Add the configs
PR Checklist
main
?