Skip to content

Conversation

lanesawyer
Copy link
Collaborator

WIP Steps

This section is optional if the PR is fully ready for review

  • Create the PR as a "draft" PR
  • Add [WIP] to the title
  • Use the template below to ask for specific feedback
  • @name: Could you look at ___? I'm trying to do... (etc.)

What

Replace this with 1-2 line Description of what feature, bugfix, chore does the PR contain the code for.

How

Replace this txt describing what kind of technical overlaying code changes were introduced here.

Screenshots

This section is optional if there are no visible changes

  • If possible add screenshots of the visible additions in the UI.
  • If there are changes in the UI, add Before and After Screenshots for quick overview.
  • If there was a Figma design, add a link to that here as well.
  • Hint : Drag and Drop any images you want to add to the PR. Also you can create a gif of an interactive version and add that!

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

// TODO: Better import setup

// RenderServerProvider must be first, as it needs to run before any other components that depend on it
// for the events to work correctly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmmm... this gives me the heebie-jeebies. Is there another way of ensuring things are done in the right order without relying on import order? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably! I haven't found the time to dig into that issue further though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants