-
Notifications
You must be signed in to change notification settings - Fork 1
Web components #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Web components #186
Conversation
// TODO: Better import setup | ||
|
||
// RenderServerProvider must be first, as it needs to run before any other components that depend on it | ||
// for the events to work correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmmm... this gives me the heebie-jeebies. Is there another way of ensuring things are done in the right order without relying on import order? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably! I haven't found the time to dig into that issue further though
WIP Steps
This section is optional if the PR is fully ready for review
What
Replace this with 1-2 line Description of what feature, bugfix, chore does the PR contain the code for.
How
Replace this txt describing what kind of technical overlaying code changes were introduced here.
Screenshots
This section is optional if there are no visible changes
PR Checklist
main
?