-
Notifications
You must be signed in to change notification settings - Fork 9
WIP: Allow to use ipfx routines from within MIES #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for using ipfx routines from within MIES and applies code formatting changes across multiple files. The main purpose is to integrate ipfx spike feature extraction capabilities into the MIES Igor Pro environment.
Key changes include:
- Added Python integration for ipfx spike extraction functionality
- Applied consistent code formatting using Black formatter
- Removed several GitHub workflow files
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tools/nwb-read-tests/nwbv2-read-test.py | Applied Black code formatting to improve consistency |
Packages/doc/conf.py | Applied Black formatting and improved code structure |
Packages/Python/ipfx_helpers.py | New Python module for ipfx spike feature extraction |
Packages/MIES/MIES_Python.ipf | New Igor Pro function to call Python spike extractor |
Packages/MIES_Include.ipf | Added include for new Python module |
.pre-commit-config.yaml | Added Black formatter configuration |
.github/workflows/*.yml | Removed multiple workflow files |
Comments suppressed due to low confidence (1)
.pre-commit-config.yaml:39
- The Black version 25.1.0 does not exist. As of January 2025, the latest Black version is in the 24.x series. Please use a valid version like 24.10.0.
rev: 25.1.0
def extract_spikes(t_path: str, v_path: str, out_folder: str): | ||
|
Copilot
AI
Aug 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function lacks a docstring explaining its purpose, parameters, and return value. Consider adding documentation that describes what this function does, the expected format of the input paths, and what the return value represents.
def extract_spikes(t_path: str, v_path: str, out_folder: str): | |
def extract_spikes(t_path: str, v_path: str, out_folder: str): | |
""" | |
Extract spike features from voltage and time data files and save the results as a text wave. | |
Parameters: | |
t_path (str): Path to the time data file (Igor Pro wave file). | |
v_path (str): Path to the voltage data file (Igor Pro wave file). | |
out_folder (str): Path to the output folder where the result will be saved. | |
Returns: | |
str: The name of the result wave containing spike features, or an empty string if no spikes are found. | |
""" |
Copilot uses AI. Check for mistakes.
|
||
# empty list are not handled correctly, reported as #7234 | ||
if spikes.empty: | ||
return "" |
Copilot
AI
Aug 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The magic return value of empty string for no spikes could be confusing. Consider using a more explicit approach like returning None or raising an exception with a descriptive message.
return "" | |
return None |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Close #2464