PSX multiple selections (only that) #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want garbage there nor AUTOMATED_TESTING_DEBUGGING defined.
Taken from 6d10790 (PSX_OperationStatsImpl: Assert on intersecting ranges, 2024-02-06).
This removes the artificial restriction introduced in 83713dd (SF Implement new select operation, 2024-10-02). We now also check that ranges from the same sweep/channel/channelType/experiment combination don't intersect.
This removes the artificial restriction introduced in 83713dd (SF Implement new select operation, 2024-10-02).
timjarsky
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timjarsky This is the multiple selections part from #2362. I'd like to fast track that as if I got you right is working already. We keep #2362 for fixing psx though.