-
Notifications
You must be signed in to change notification settings - Fork 9
Various PSX fixes #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
t-b
wants to merge
65
commits into
main
Choose a base branch
from
bugfix/2362-psx-support-multiple-selections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Various PSX fixes #2362
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
24c6d11
PSX_RestoreGuiState: Prefer GUI control setter over PGC
t-b 467c867
PSX_GetEventIndexAndComboIndex: Handle vs in keyboard navigation
t-b 419ef3e
PSX: Tweak detection algorithm
timjarsky b5b49a1
PSX: Calculate the starting point for the average fit better
t-b 61d1645
PSX_GetEventFitRange: Change starting position
t-b 44b93c8
PSX_CalculateEventProperties: Tweak baseline calculation
t-b 40f45a7
UTF_SweepFormula_PSX.ipf: Fix tests
t-b 969f4ba
PSX_GetGoodTau: Handle edge case
t-b 796ca00
PSX_PlotStartupSettings: Handle no userdata properly
t-b bce4b84
MIES_SweepFormula_PSX.ipf: Tweak PSX_TAU_CALC_FACTOR
timjarsky c2629d7
MIES_SweepFormula_PSX.ipf: Tweak peak and baseline calculation
t-b 80971bb
PSX_CalculateRiseTime: Factor it out
t-b 3da8142
PSX_CalculateRiseTime: Return error when xStart is NaN
t-b 1a80379
PSX_UpdateDisplayedFit: Remove yOffset
t-b 0b8b612
PSX_FitAcceptAverage: Use different method for calculating start posi…
t-b 111fccf
MIES_SweepFormula_PSX.ipf: Revise event peak and baseline calculation
t-b ed7cbe3
PSX_GetEventFitRange/PSX_FitEventDecay: Revise them
t-b dfbebf0
PSX_FitEventDecay: Switch from single exponential to double exponenti…
timjarsky c04798e
PSX_FitAcceptAverage: Multiple simultaneous fits to the accepted all …
timjarsky 31e9eb8
PSX_FilterEventsKernelAmpSign: Ignore events with non-finite deconv v…
t-b c977b8f
PSX: Add more vertical lines for peak_t and baseline_t
t-b c3b950a
PSX_FitEventDecay: Support three tau instead of one
t-b 76ee433
PSX_AppendTracesToAllEventGraph: Fix function comment
t-b 57b1b6d
stopping the collapse of the universe by filtering out negative time …
timjarsky d45b953
another tau filter
timjarsky 3f82efa
BandPassWithRingingDetection: Add it
timjarsky c1f58e7
psxDeconvFilter: Rework it
t-b ea04883
MIES_SweepFormula_PSX.ipf: Document SweepFormula operation signatures
t-b ca6d2ed
psxSweepBPFilter: Add it
t-b 51541ed
PSX_FilterSweepData/PSX_DeconvoluteSweepData: Always make order even
t-b cbf2ccc
SFH_GetArgumentAsNumeric: Add assertion
t-b 43ab30a
BandPassWithRingingDetection: Minor cleanup
t-b 6f3bf66
BandPassWithRingingDetection: Remove the offset for every iteration
t-b 97d1ae5
BandPassWithRingingDetection: Reorganize the code
t-b 351502f
PSX_Operation: Fix data gathering after failure
t-b b8b30da
PSX_Operation: Backdown filtering order
t-b 954e30d
MIES_SweepFormula_PSX.ipf: Check number of arguments in all operations
t-b a7462db
SF_CheckInputCode: Preprocess code
t-b 0ef1eb2
Packages/doc/SweepFormula.rst: Update it
t-b 1b5d868
PSX: Use 2^x padding for FFT input
t-b f123986
PSX: Prefer odd number of historgram bins
timjarsky c165ceb
Revert "PSX: Use 2^x padding for FFT input"
timjarsky bf5f6dd
PSX_FitAcceptAverage: Calculate maximum of it as well
t-b 7aa2be6
PSX: Add average fit for all states
t-b b16326f
MakeWaveFree: Make it threadsafe
t-b 0a85d57
tools/check-code.sh: Teach the test assertion check support for NOLINT
t-b 8313a73
MIES_Utilities_Algorithm.ipf: Add helper routines for DoFFT
t-b a2ad471
SF_SetStatusDisplay: Make it available for all
t-b 5ddd976
PSX: Implement sweep data shortening for faster FFT
t-b c9e7854
PSX: Supply default values for filtering derived from the kernel
t-b 80451b5
GetInterpolatedYValue: Add it with tests
t-b 8114257
PSX: Add Onset and Rise y values to psxEvent
t-b 5c317af
PSX_FitAverage: Store fit results in datafolder hierarchy
t-b f98435d
Packages/doc/SweepFormula.rst: Add units for rise and decay tau
t-b 8fe2f53
PSX_UpdateBlockIndizes: Remove unused restrictCurrentCombo variable
t-b 79100a9
PSX_Operation: Add peakThreshold to parameter JSON
t-b 17506ee
JSONToWave/WaveTypeStringToNumber: Add support for unsigned integer w…
t-b 91f34bc
PSX_OperationStatsImpl: Output more entries for stats postprocessing
t-b 3b74672
Tim's questionable changes :)
timjarsky bb473f3
PSX_UpdateAverageTraces: Fix indexing confusion
t-b d94a574
new function to determine the fit end time for the decay to the avera…
timjarsky ab66bfc
Update Packages/MIES/MIES_SweepFormula_PSX.ipf
timjarsky f7489e2
Update Packages/MIES/MIES_SweepFormula_PSX.ipf
timjarsky df910ad
stand alone function to get kernel decay tau
timjarsky 76b5943
PSX fixes
timjarsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion uses compound logical operators (&&) which the test framework check was designed to flag. Consider breaking this into separate assertions for each condition to improve clarity and debugging.
Copilot uses AI. Check for mistakes.