Skip to content

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jul 8, 2024

Implement a MVP

  • Don't support vs
  • AppendToTable with with
  • Multiple tables with and
table(0...10)

gives

image

@t-b t-b self-assigned this Jul 8, 2024
@t-b t-b removed their assignment Feb 21, 2025
@timjarsky timjarsky requested a review from Copilot August 7, 2025 17:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a minimum viable product (MVP) for the table operation in SweepFormula, allowing data to be displayed in a table format instead of the default graph view.

  • Adds a new table operation that can be applied to datasets
  • Modifies the plotting logic to display data as an editable table when the table operation is used
  • Implements basic table functionality without support for advanced features like vs, with, or and operations


WAVE/WAVE input = SF_ResolveDatasetFromJSON(jsonId, jsonPath, graph, 0)

WAVE/WAVE output = SFH_CreateSFRefWave(graph, SF_OP_DERIVATIVE, DimSize(input, ROWS))
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is creating a reference wave using SF_OP_DERIVATIVE constant instead of SF_OP_TABLE. This should be SF_OP_TABLE to maintain consistency with the operation being performed.

Suggested change
WAVE/WAVE output = SFH_CreateSFRefWave(graph, SF_OP_DERIVATIVE, DimSize(input, ROWS))
WAVE/WAVE output = SFH_CreateSFRefWave(graph, SF_OP_TABLE, DimSize(input, ROWS))

Copilot uses AI. Check for mistakes.


output[] = input[p]

JWN_SetNumberInWaveNote(input, "Table", 1)
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table flag is being set on the input wave instead of the output wave. This means the flag will be applied to the original data rather than the processed output, which could affect other operations that use the same input data. This should be applied to the output wave elements instead.

Suggested change
JWN_SetNumberInWaveNote(input, "Table", 1)
JWN_SetNumberInWaveNote(output, "Table", 1)

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant