Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lightweight its::GeometryTGeo instead of full geometry #2164

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Use lightweight its::GeometryTGeo instead of full geometry #2164

merged 2 commits into from
Mar 6, 2024

Conversation

shahor02
Copy link
Contributor

@shahor02 shahor02 commented Mar 3, 2024

No description provided.

@shahor02 shahor02 requested a review from diana0x0f as a code owner March 4, 2024 14:21
@Barthelemy
Copy link
Collaborator

This is ok for me, there is a test failing though (full system test)

@iravasen
Copy link
Collaborator

iravasen commented Mar 5, 2024

Hi @Barthelemy, most probably the test O2fst is failing because of the modifications on the jsons. One should do the same in this json: https://github.com/AliceO2Group/O2DPG/blob/master/DATA/production/qc-sync/its.json

Hi @shahor02, thanks a lot for the PR! Should we test it locally or you did it already?

@iravasen
Copy link
Collaborator

iravasen commented Mar 5, 2024

I can take care of O2DPG after lunch

@shahor02
Copy link
Contributor Author

shahor02 commented Mar 5, 2024

I am testing it locally...

@shahor02
Copy link
Contributor Author

shahor02 commented Mar 5, 2024

The problem was on the O2 side, need to wait for AliceO2Group/AliceO2#12809 merged.

@iravasen iravasen mentioned this pull request Mar 5, 2024
Merged
@shahor02
Copy link
Contributor Author

shahor02 commented Mar 6, 2024

@Barthelemy, the CI is green now.

@Barthelemy
Copy link
Collaborator

@shahor02 Thank you !

@Barthelemy Barthelemy merged commit ec93049 into AliceO2Group:master Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iravasen iravasen Awaiting requested review from iravasen iravasen is a code owner

@IsakovAD IsakovAD Awaiting requested review from IsakovAD IsakovAD is a code owner

@diana0x0f diana0x0f Awaiting requested review from diana0x0f diana0x0f is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahor02 @Barthelemy @iravasen