-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New grpGeomRequest for ITS and MFT jsons #1522
Conversation
…igth geometry files
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iravasen
Looks fine to me but better MFT experts also check. I've just noticed, that in opposite to the original QualityControl/Modules/MFT/mft-tracks.json the O2DPG/Data/production/qc-async/mft.json was not requesting the GRPGeom block for the MFTTracks task. This means that the call https://github.com/AliceO2Group/QualityControl/blob/55da459a99b14b920255998b1c40148dce48603f/Modules/MFT/src/QcMFTTrackTask.cxx#L211 was returning default 128 orbits / TF
Hello @iravasen , Chiara |
Hi, after discussing with the MFT QC team these changes are ok from our side. Do you also plan to modify the config files in consul or should we do it ourselves once we have the new FLPSuite ? |
Thanks @iravasen , @mcoquet642 ! |
Hi @Barthelemy @shahor02, I guess now this PR can be merged? |
Yes! Once the new QC is deployed at P2, one can change also jsons on consul. |
Hello @iravasen , I guess I can merge now. And I also think that this is needed in view of the memory reduction for QC, right? Chiara |
Yes thanks! Sorry |
Now there are conflicts... |
This follows AliceO2Group/QualityControl#2164
and has to go together with it!
Before merge wait approval from MFT colleagues.