Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCH: implementation of QC review suggestions #2114

Merged
merged 7 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Modules/MUON/Common/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ set(MODULE_NAME "O2QcMUONCommon")

set(SRCS
src/Helpers.cxx
src/MergeableTH1Ratio.cxx
src/MergeableTH2Ratio.cxx
src/HistPlotter.cxx
src/MuonTrack.cxx
src/TrackPlotter.cxx
Expand All @@ -14,8 +12,6 @@ set(SRCS
)

set(HEADERS
include/MUONCommon/MergeableTH1Ratio.h
include/MUONCommon/MergeableTH2Ratio.h
include/MUONCommon/HistPlotter.h
include/MUONCommon/MuonTrack.h
include/MUONCommon/TrackCheck.h
Expand All @@ -33,7 +29,7 @@ target_include_directories(
PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src
)

target_link_libraries(${MODULE_NAME} PUBLIC O2QualityControl O2::MCHMappingImpl4 O2::DataFormatsMCH O2::MCHTracking O2::MCHRawElecMap O2::ReconstructionDataFormats O2::MCHGeometryTransformer O2::DataFormatsGlobalTracking)
target_link_libraries(${MODULE_NAME} PUBLIC O2QualityControl O2QcCommon O2::MCHMappingImpl4 O2::DataFormatsMCH O2::MCHTracking O2::MCHRawElecMap O2::ReconstructionDataFormats O2::MCHGeometryTransformer O2::DataFormatsGlobalTracking)

# Digit.h is moving from MCHBase to DataFormatsMCH : let's handle both
# gracefully for the moment...
Expand All @@ -52,9 +48,7 @@ install(
# ---- ROOT dictionary ----

add_root_dictionary(${MODULE_NAME}
HEADERS include/MUONCommon/MergeableTH1Ratio.h
include/MUONCommon/MergeableTH2Ratio.h
include/MUONCommon/TrackPlotter.h
HEADERS include/MUONCommon/TrackPlotter.h
include/MUONCommon/TracksCheck.h
include/MUONCommon/TracksTask.h
LINKDEF include/MUONCommon/LinkDef.h)
Expand Down
2 changes: 0 additions & 2 deletions Modules/MUON/Common/include/MUONCommon/LinkDef.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
#pragma link off all classes;
#pragma link off all functions;

#pragma link C++ class o2::quality_control_modules::muon::MergeableTH1Ratio + ;
#pragma link C++ class o2::quality_control_modules::muon::MergeableTH2Ratio + ;
#pragma link C++ class o2::quality_control_modules::muon::TrackPlotter + ;
#pragma link C++ class o2::quality_control_modules::muon::TracksTask + ;
#pragma link C++ class o2::quality_control_modules::muon::TracksCheck + ;
Expand Down
73 changes: 0 additions & 73 deletions Modules/MUON/Common/include/MUONCommon/MergeableTH1Ratio.h

This file was deleted.

86 changes: 0 additions & 86 deletions Modules/MUON/Common/include/MUONCommon/MergeableTH2Ratio.h

This file was deleted.

151 changes: 0 additions & 151 deletions Modules/MUON/Common/src/MergeableTH1Ratio.cxx

This file was deleted.

Loading
Loading