MCH: implementation of QC review suggestions #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MergeableTHxRatio classes are now a duplicate of the THxRatio classes available in the framework, and can be removed to avoid code duplication
- the MCHAggregator is a duplicate of WorstOfAllAggregator - the QualityPostProcessing is a duplicate of QualityTask - the QualityCheck and sampa_header.h are not used
The new code simplifies the update logic and makes the class compatible with THxRatio objects
- removed unneeded headers - moved functions implementation out of headers - updated sources authors lists
Barthelemy
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the suggestions received during the MCH QC review (https://indico.cern.ch/event/1344912/).
Summary of code changes: