coverage report untested files (and misc cleanup) #10556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
added
automerge:rebase
Deploying agoric-sdk with
|
| Latest commit: |
8efce30
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b676ca46.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-codecov-cleanup.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Nov 22, 2024
turadg
force-pushed
the
ta/codecov-cleanup
branch
from
006ad76 to
f22763f
Compare
turadg
force-pushed
the
ta/codecov-cleanup
branch
from
f22763f to
8efce30
Compare
|
Turns out the master CI job that calls |
Merged
mergify bot
added a commit
that referenced
this pull request
Nov 23, 2024
followup: #10556 ## Description #10556 removed C8_OPTIONS without looking closely at the fence. That parameter was used by the `test:c8-all` command to stitch together the package coverage collections. This restores that and adds some documentation. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations [manual trigger the after-merge branch](https://github.com/Agoric/agoric-sdk/actions/runs/11984250775) to verify the build output at https://agoric-sdk-coverage.netlify.app/ before merging. UPDATE: `coverage` only runs on `push` so the manual trigger didn't work. I suppose so a random branch doesn't overwrite the master coverage report. ### Upgrade Considerations none
mergify bot
added a commit
that referenced
this pull request
Nov 23, 2024
refs: #10559 ## Description #10556 made coverage reports include all files, but only in package reports. This makes CI's report across all packages also use `--all`. While working on this I wanted to be able to document all the kinks I ran into so I also consolidated this capability in a single script with explanatory comments. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations includes docs now ### Testing Considerations The `coverage` job runs in the after-merge workflow but only on `push` so I can't trigger it in CI. Instead I've run the script locally. When it reaches cosmic-swingset it dies on `./bin/rosetta-cli` but I just skipped that package and confirmed the generated report is as expected. ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
The main change in this PR is to make the code coverage reports include files that aren't tested at all (or apparently aren't due to the bundling problem #1817)
It also cleans up a bunch of obsolete stuff about NESM and adds some more usage docs.
Security Considerations
none
Scaling Considerations
n/a
Documentation Considerations
Improves
Testing Considerations
I ran the commands locally to verify the reports. Once this lands they'll appear at https://agoric-sdk-coverage.netlify.app/
Upgrade Considerations
n/a