Skip to content

Commit 62aabb6

Browse files
authored
fix c8-all (#10559)
followup: #10556 ## Description #10556 removed C8_OPTIONS without looking closely at the fence. That parameter was used by the `test:c8-all` command to stitch together the package coverage collections. This restores that and adds some documentation. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations [manual trigger the after-merge branch](https://github.com/Agoric/agoric-sdk/actions/runs/11984250775) to verify the build output at https://agoric-sdk-coverage.netlify.app/ before merging. UPDATE: `coverage` only runs on `push` so the manual trigger didn't work. I suppose so a random branch doesn't overwrite the master coverage report. ### Upgrade Considerations none
2 parents 5cfb99b + 3eb1a1d commit 62aabb6

File tree

32 files changed

+38
-31
lines changed

32 files changed

+38
-31
lines changed

Diff for: COVERAGE.md

+7
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,16 @@ source-to-source transforms (such as `@endo/bundle-source`,
88

99
## Reports
1010

11+
### Whole repo
1112
Coverage reports for the current main branch are
1213
published by CI to: https://agoric-sdk-coverage.netlify.app
1314

15+
It's made by a CI job calling `test:c8-all` in the project root. That in turn
16+
calls `test:c8` in each package, with `$C8_OPTIONS` set to a common coverage
17+
directory and to leave temp files so they can accumulate. The job then uses that
18+
output in another call to c8 to generate a report.
19+
20+
## Per package
1421
You can create a report in any package:
1522

1623
```sh

Diff for: packages/ERTP/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"prepack": "tsc --build tsconfig.build.json",
1313
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1414
"test": "ava",
15-
"test:c8": "c8 $C8_OPTIONS ava",
15+
"test:c8": "c8 --all $C8_OPTIONS ava",
1616
"test:xs": "yarn test:xs-worker",
1717
"test:xs-unit": "exit 0",
1818
"test:xs-worker": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 test/swingsetTests",

Diff for: packages/access-token/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"scripts": {
1111
"build": "exit 0",
1212
"test": "ava",
13-
"test:c8": "c8 --all ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint": "run-s --continue-on-error lint:*",
1616
"lint-fix": "yarn lint:eslint --fix",

Diff for: packages/agoric-cli/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"scripts": {
2121
"build": "node ./scripts/get-sdk-package-names.js > src/sdk-package-names.js",
2222
"test": "ava",
23-
"test:c8": "c8 --all ava",
23+
"test:c8": "c8 --all $C8_OPTIONS ava",
2424
"test:xs": "exit 0",
2525
"integration-test": "ava --config .ava-integration-test.config.js",
2626
"lint-fix": "yarn lint:eslint --fix",

Diff for: packages/async-flow/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"prepack": "tsc --build tsconfig.build.json",
1111
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1212
"test": "ava",
13-
"test:c8": "c8 --all ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint-fix": "yarn lint:eslint --fix",
1616
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/base-zone/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"prepack": "tsc --build tsconfig.build.json",
1111
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1212
"test": "ava",
13-
"test:c8": "c8 --all ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint-fix": "yarn lint:eslint --fix",
1616
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/cache/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"scripts": {
99
"build": "exit 0",
1010
"test": "ava",
11-
"test:c8": "c8 --all ava",
11+
"test:c8": "c8 --all $C8_OPTIONS ava",
1212
"test:xs": "exit 0",
1313
"lint-fix": "yarn lint:eslint --fix",
1414
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/casting/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1212
"demo": "node -e 'import(\"./test/fake-rpc-server.js\").then(ns => ns.develop())'",
1313
"test": "ava",
14-
"test:c8": "c8 --all ava",
14+
"test:c8": "c8 --all $C8_OPTIONS ava",
1515
"test:xs": "exit 0",
1616
"lint-fix": "yarn lint:eslint --fix",
1717
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/client-utils/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"scripts": {
1515
"build": "exit 0",
1616
"test": "ava",
17-
"test:c8": "c8 --all ava",
17+
"test:c8": "c8 --all $C8_OPTIONS ava",
1818
"test:xs": "exit 0",
1919
"lint-fix": "yarn lint:eslint --fix",
2020
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/cosmic-swingset/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"scripts": {
1212
"build": "exit 0",
1313
"test": "ava",
14-
"test:c8": "c8 --all ava",
14+
"test:c8": "c8 --all $C8_OPTIONS ava",
1515
"test:xs": "exit 0",
1616
"lint-fix": "yarn lint:eslint --fix",
1717
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/create-dapp/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"scripts": {
1313
"build": "exit 0",
1414
"test": "ava",
15-
"test:c8": "c8 --all ava",
15+
"test:c8": "c8 --all $C8_OPTIONS ava",
1616
"test:xs": "exit 0",
1717
"lint-fix": "yarn lint:eslint --fix",
1818
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/fast-usdc/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "exit 0",
1515
"test": "ava",
16-
"test:c8": "c8 --all ava",
16+
"test:c8": "c8 --all $C8_OPTIONS ava",
1717
"test:xs": "exit 0",
1818
"lint-fix": "yarn lint:eslint --fix",
1919
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/governance/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"prepack": "tsc --build tsconfig.build.json",
1414
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1515
"test": "ava",
16-
"test:c8": "c8 --all ava",
16+
"test:c8": "c8 --all $C8_OPTIONS ava",
1717
"test:xs": "exit 0",
1818
"lint-fix": "yarn lint:eslint --fix",
1919
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/import-manager/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"scripts": {
1111
"build": "exit 0",
1212
"test": "ava",
13-
"test:c8": "c8 --all ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint": "yarn lint:eslint",
1616
"lint-fix": "yarn lint:eslint --fix",

Diff for: packages/inter-protocol/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"prepack": "tsc --build tsconfig.build.json",
1414
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1515
"test": "ava",
16-
"test:c8": "c8 --all ava",
16+
"test:c8": "c8 --all $C8_OPTIONS ava",
1717
"test:xs": "exit 0",
1818
"lint-fix": "yarn lint:eslint --fix",
1919
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/kmarshal/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "exit 0",
1515
"test": "ava",
16-
"test:c8": "c8 --all ava",
16+
"test:c8": "c8 --all $C8_OPTIONS ava",
1717
"test:xs": "exit 0",
1818
"lint-fix": "yarn lint:eslint --fix",
1919
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/network/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"prepack": "tsc --build tsconfig.build.json",
1111
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1212
"test": "ava",
13-
"test:c8": "c8 $C8_OPTIONS ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint-fix": "yarn lint:eslint --fix",
1616
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/notifier/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"prepack": "tsc --build tsconfig.build.json",
1313
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1414
"test": "ava",
15-
"test:c8": "c8 --all ava",
15+
"test:c8": "c8 --all $C8_OPTIONS ava",
1616
"test:xs": "exit 0",
1717
"lint-fix": "yarn lint:eslint --fix",
1818
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/orchestration/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"prepack": "tsc --build tsconfig.build.json",
1515
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1616
"test": "ava",
17-
"test:c8": "c8 --all ava",
17+
"test:c8": "c8 --all $C8_OPTIONS ava",
1818
"test:xs": "exit 0",
1919
"lint": "run-s --continue-on-error lint:*",
2020
"lint:types": "tsc",

Diff for: packages/pegasus/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"scripts": {
1111
"build": "exit 0",
1212
"test": "ava",
13-
"test:c8": "c8 --all ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint-fix": "yarn lint:eslint --fix",
1616
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/solo/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"scripts": {
1212
"build": "exit 0",
1313
"test": "ava",
14-
"test:c8": "c8 --all ava",
14+
"test:c8": "c8 --all $C8_OPTIONS ava",
1515
"test:xs": "exit 0",
1616
"lint-fix": "yarn lint:eslint --fix",
1717
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/spawner/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"build": "yarn build:bundles",
1212
"build:bundles": "node scripts/build-bundles.js",
1313
"test": "ava",
14-
"test:c8": "c8 --all ava",
14+
"test:c8": "c8 --all $C8_OPTIONS ava",
1515
"test:xs": "exit 0",
1616
"lint": "run-s --continue-on-error lint:*",
1717
"lint-fix": "yarn lint:eslint --fix",

Diff for: packages/swing-store/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"build": "exit 0",
1515
"test": "ava",
16-
"test:c8": "c8 --all ava",
16+
"test:c8": "c8 --all $C8_OPTIONS ava",
1717
"test:xs": "exit 0",
1818
"lint-fix": "yarn lint:eslint --fix",
1919
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/swingset-runner/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"scripts": {
1212
"build": "exit 0",
1313
"test": "ava",
14-
"test:c8": "c8 --all ava",
14+
"test:c8": "c8 --all $C8_OPTIONS ava",
1515
"test:xs": "exit 0",
1616
"lint-fix": "yarn lint:eslint --fix",
1717
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/swingset-xsnap-supervisor/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"lint:types": "tsc",
2020
"lint-fix": "eslint --fix 'lib/**/*.js' 'src/**/*.js' 'scripts/**/*.js' 'test/**/*.js'",
2121
"test": "ava",
22-
"test:c8": "c8 --all ava",
22+
"test:c8": "c8 --all $C8_OPTIONS ava",
2323
"test:xs": "exit 0"
2424
},
2525
"devDependencies": {

Diff for: packages/telemetry/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"scripts": {
99
"build": "exit 0",
1010
"test": "ava",
11-
"test:c8": "c8 --all ava",
11+
"test:c8": "c8 --all $C8_OPTIONS ava",
1212
"test:xs": "exit 0",
1313
"lint-fix": "yarn lint:eslint --fix",
1414
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/vats/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"prepack": "tsc --build tsconfig.build.json",
1212
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1313
"test": "ava",
14-
"test:c8": "c8 $C8_OPTIONS ava",
14+
"test:c8": "c8 --all $C8_OPTIONS ava",
1515
"test:xs": "exit 0",
1616
"lint-fix": "yarn lint:eslint --fix",
1717
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/vm-config/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"scripts": {
99
"build": "exit 0",
1010
"test": "ava",
11-
"test:c8": "c8 --all ava",
11+
"test:c8": "c8 --all $C8_OPTIONS ava",
1212
"test:xs": "exit 0",
1313
"lint-fix": "yarn lint:eslint --fix",
1414
"lint": "run-s --continue-on-error lint:*",

Diff for: packages/xsnap-lockdown/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"lint:types": "tsc",
1717
"lint-fix": "eslint --fix 'src/**/*.js' 'lib/**/*.js' 'scripts/**/*.js' 'test/**/*.js'",
1818
"test": "ava",
19-
"test:c8": "c8 --all ava",
19+
"test:c8": "c8 --all $C8_OPTIONS ava",
2020
"test:xs": "exit 0"
2121
},
2222
"devDependencies": {

Diff for: packages/xsnap/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"lint:types": "tsc",
2525
"lint-fix": "eslint --fix 'src/**/*.js' 'test/**/*.js' api.js",
2626
"test": "ava",
27-
"test:c8": "c8 --all ava",
27+
"test:c8": "c8 --all $C8_OPTIONS ava",
2828
"test:xs": "exit 0"
2929
},
3030
"dependencies": {

Diff for: packages/zoe/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"prepack": "tsc --build tsconfig.build.json",
1414
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1515
"test": "ava --verbose",
16-
"test:c8": "c8 --all ava",
16+
"test:c8": "c8 --all $C8_OPTIONS ava",
1717
"test:unit": "ava 'test/unitTests' -T 1m --verbose",
1818
"test:swingset": "ava 'test/swingsetTests' -T 10m --verbose",
1919
"test:xs": "yarn test:xs-worker",

Diff for: packages/zone/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"prepack": "tsc --build tsconfig.build.json",
1111
"postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'",
1212
"test": "ava",
13-
"test:c8": "c8 --all ava",
13+
"test:c8": "c8 --all $C8_OPTIONS ava",
1414
"test:xs": "exit 0",
1515
"lint-fix": "yarn lint:eslint --fix",
1616
"lint": "run-s --continue-on-error lint:*",

0 commit comments

Comments
 (0)