Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: '-' in Html(Data)Table Ids prevent using modal windows #1743

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

MightyMCoder
Copy link
Member

fixes #1741: couldn't use modal windows in HtmlDataTables


I also checked all HtmlTable initializations so hopefully I found all occurrences (only 2?).
@Fasse: Maybe you can check again?

@MightyMCoder MightyMCoder added this to the v4.3.14 milestone Jan 28, 2025
@MightyMCoder MightyMCoder requested a review from Fasse January 28, 2025 20:40
@MightyMCoder MightyMCoder self-assigned this Jan 28, 2025
@MightyMCoder MightyMCoder linked an issue Jan 28, 2025 that may be closed by this pull request
adm_program/system/classes/ModuleDocumentsFiles.php Outdated Show resolved Hide resolved
adm_program/system/classes/ModuleGroupsRoles.php Outdated Show resolved Hide resolved
@MightyMCoder MightyMCoder requested a review from Fasse January 29, 2025 15:37
@MightyMCoder MightyMCoder merged commit 5c8616e into v4.3 Jan 29, 2025
@MightyMCoder MightyMCoder deleted the fix-HtmlDataTable branch January 29, 2025 18:45
@Fasse Fasse removed this from the v4.3.14 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't delete files in module documents and files anymore
2 participants