Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't delete files in module documents and files anymore #1741

Closed
MightyMCoder opened this issue Jan 28, 2025 · 4 comments · Fixed by #1743
Closed

Couldn't delete files in module documents and files anymore #1741

MightyMCoder opened this issue Jan 28, 2025 · 4 comments · Fixed by #1743
Assignees
Milestone

Comments

@MightyMCoder
Copy link
Member

After applying #1736 it is not longer possible to delete files in "documents and files" (see Forum Post 35754).

Problem:

The HtmlTable in "documents and files" is created with '-' in the ID:
$page = new ModuleDocumentsFiles('admidio-documents-files', $headline);

Possible fixes:

  1. replace all '-' with '_' in all HtmlTable creations.
  2. replace all '-' with '_' in HtmlDataTable.php before adding the ID to the JavaScript constant declaration.

@Fasse: What is your preferred fix? What do you think?

@Fasse
Copy link
Member

Fasse commented Jan 28, 2025

Replace all - with _ in all HtmlTable creations would be a good idea because in Admidio 5 this is the default syntax for ids.

@Fasse
Copy link
Member

Fasse commented Jan 28, 2025

Also in Admidio 5 most IDs should have a prefix adm_

@Fasse
Copy link
Member

Fasse commented Jan 29, 2025

This must also be fixed in the master.

@Fasse Fasse reopened this Jan 29, 2025
@MightyMCoder
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants