Refactor, feat: Select dialog#1275
Merged
bajrangCoder merged 7 commits intoAcode-Foundation:mainfrom Apr 23, 2025
Merged
Conversation
bajrangCoder
requested changes
Apr 23, 2025
Member
bajrangCoder
left a comment
bajrangCoder
left a comment
There was a problem hiding this comment.
Everything is fine just one formatting error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr refactor the
Selectdialog code and add new features.Features
Demo
Discussion
Should we deprecate the support of array in items? And keep only Object and Sting only in future? Because it's seems not practical.