Skip to content

Conversation

@bajrangCoder
Copy link
Member

  • Added tail property in select box to add tail elements like x for deleting
  • Fixed issues related to event handling
  • Fixed issues started due to some missing code(followup for Refactor, feat: Select dialog #1275 )
  • Added x icon in select box to delete recent files/folder(Fixes: Add folder removal option #1130)
  • Also sanitize the html before adding to dom

@bajrangCoder bajrangCoder requested a review from Copilot May 9, 2025 14:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues with the select box component by fixing event handling problems, adding a tail element to enable deletion actions, and sanitizing HTML before insertion. Key changes include:

  • Introducing tail elements and associated click handlers in both file and directory entries.
  • Updating the select dialog to sanitize HTML text via DOMPurify.
  • Minor refactoring to improve clarity in event management and DOM cleanup.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/lib/recents.js Refactored folder and file item rendering with added tail elements and corresponding click handlers.
src/dialogs/select.js Updated select dialog to use template literals, sanitized HTML, and implemented tail click handler registration and cleanup.

bajrangCoder and others added 3 commits May 9, 2025 20:23
@bajrangCoder bajrangCoder merged commit d0523e3 into Acode-Foundation:main May 9, 2025
2 checks passed
@bajrangCoder bajrangCoder deleted the fix/select-box-issues branch May 9, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add folder removal option

1 participant