Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update terminology from 'stream' to 'channel' #1574

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

update terminology from 'stream' to 'channel' #1574

wants to merge 6 commits into from

Conversation

Gopinath-Mahendiran
Copy link

What does this PR do, and why?

This PR introduces support for dynamically updating UI terminology based on the current feature_level.

•	Refactored label and message text sources to respond to the feature_level value.
•	Introduced centralized terminology management logic to allow conditional term switching.
•	Ensured backward compatibility with previous terminology when feature_level is below the threshold.
•	Updated affected UI components to pull display terms dynamically instead of using hardcoded strings.

Outstanding aspect(s)

still need to change the code base terminologies

External discussion & connections

  • [ x] Discussed in #zulip-terminal in topic
  • Fully fixes #
  • [ x] Partially fixes issue Migrate from 'Stream' to 'Channel' naming #1510
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • [x ] Merge will enable work on # code base terminology changes

How did you test this?

  • [ x] Manually - Behavioral changes
  • [ x] Manually - Visual changes
  • [x ] Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • [ x] Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • [ x] It is a minimal coherent idea
  • [ x] It has a commit summary following the documented style (title & body)
  • [x ] It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

Visual changes

Screenshot 2025-04-04 at 7 38 39 PM

@zulipbot zulipbot added size: XL [Automatic label added by zulipbot] area: documentation Requires changes in documentation area: UI General user interface update high priority should be done as soon as possible TRACKING version parity: 9 labels Apr 4, 2025
@Gopinath-Mahendiran
chore(ui): Update terminology from 'stream' to 'channel'
a194b14 
- Dynamically changing the terminology according to the feature_level in ui.
- Added dos for the changes.
- Not changed the terminologies in the code base.

partially fixes zulip#1510
@Gopinath-Mahendiran
fix : Linitng issue
f55cd24 
- fixing the linting issue.
@Gopinath-Mahendiran
lint : Fixes the linting issue
736628d 
-changes made in lint-hotkeys.
-ensure the correctness
@Gopinath-Mahendiran
fix : Changes done in test files
f165daa 
- changes done in test files according to key_binding.
@Gopinath-Mahendiran
fix : Fix Failed test
cb9cbde 
- make sure it passes all the test.
- some linting as well.
@Gopinath-Mahendiran
fix : Fixed error in helpview
b016505 
- Fixed error in helpview, encountered while viewing the help section.
- other small fixes
@Gopinath-Mahendiran
Copy link
Author

@neiljp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: documentation Requires changes in documentation area: UI General user interface update high priority should be done as soon as possible size: XL [Automatic label added by zulipbot] TRACKING version parity: 9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gopinath-Mahendiran @zulipbot