Skip to content

Refactor KaTeX parsing of inline styles and vlists; normalize survey output a bit more #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
+235 −254
Open

Refactor KaTeX parsing of inline styles and vlists; normalize survey output a bit more #1722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8c4106d
katex [nfc]: Show line numbers only on unknown hard-fails, not others
gnprice Jul 19, 2025
d269628
katex [nfc]: Add messages for remaining hard-fail cases seen in corpus
gnprice Jul 19, 2025
e74557b
tools/content [nfc]: Tie-break on reason text when number of failures…
gnprice Jul 19, 2025
16deb86
katex [nfc]: Cut stray import of widgets library
gnprice Jul 19, 2025
3a9ed06
binding [nfc]: Cut stray import of a widgets library
gnprice Jul 19, 2025
46c74e7
katex [nfc]: Fix a variable name to specify its units, namely em
gnprice Jul 18, 2025
e223229
katex: Require height on pstrut spans
gnprice Jul 18, 2025
b62979c
katex [nfc]: Separate _parseInlineStyles from constructing a KatexSpa…
gnprice Jul 18, 2025
a88de14
katex [nfc]: Push more parsing into _parseInlineStyles; return Map
gnprice Jul 18, 2025
57b980e
katex [nfc]: Factor out _takeStyleEm from _parseSpanInlineStyles
gnprice Jul 18, 2025
ade7f66
katex: Fix a misleading log line: unexpected CSS property, not value
gnprice Jul 18, 2025
9c32bd6
katex [nfc]: Skip building whole KatexSpanStyles for struts' two prop…
gnprice Jul 18, 2025
6c2e55c
katex [nfc]: Cut vertical-align from generic style properties
gnprice Jul 18, 2025
f12c749
katex [nfc]: Check "only has height" directly, without making KatexSp…
gnprice Jul 18, 2025
e1a2c9c
katex [nfc]: Get pstrut height directly, without making KatexSpanStyles
gnprice Jul 18, 2025
7443e1a
katex [nfc]: Directly handle expected inline styles on vlist child
gnprice Jul 18, 2025
8e059b3
katex: Don't expect height on vlist child spans
gnprice Jul 19, 2025
e61c6c7
katex [nfc]: Consolidate logic for computing overall styles of KatexS…
gnprice Jul 18, 2025
77b1c2f
katex [nfc]: Inline remaining/main use of _parseSpanInlineStyles
gnprice Jul 18, 2025
636ac6a
katex [nfc]: Construct vlist child's styles directly, without filter
gnprice Jul 18, 2025
465dc25
katex [nfc]: Dedupe logic for vlist child between margin/no-margin cases
gnprice Jul 18, 2025
c744e45
katex [nfc]: Note that heightEm might turn out not to be needed
gnprice Jul 19, 2025
e9bbdcc
katex [nfc]: Simplify extracting from attrs map in _parseInlineStyles
gnprice Jul 19, 2025
26ac991
katex [nfc]: Split out _parseStrut, _parseVlist, _parseGenericSpan
gnprice Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/model/binding.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:wakelock_plus/wakelock_plus.dart' as wakelock_plus;
import '../host/android_notifications.dart';
import '../host/notifications.dart' as notif_pigeon;
import '../log.dart';
import '../widgets/store.dart';
import 'store.dart';

export 'package:file_picker/file_picker.dart' show FilePickerResult, FileType, PlatformFile;
Expand Down
Loading