Skip to content

fix:Rework and enable tests for Merels. #433 #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 69 additions & 6 deletions zulip_bots/zulip_bots/bots/merels/test_merels.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
from typing import Any, List, Tuple
from typing import Any, Dict, List, Tuple

from typing_extensions import override

from zulip_bots.bots.merels.libraries.constants import EMPTY_BOARD
from zulip_bots.game_handler import GameInstance
from zulip_bots.test_lib import BotTestCase, DefaultTests

from .libraries.constants import EMPTY_BOARD


class TestMerelsBot(BotTestCase, DefaultTests):
bot_name = "merels"

@override
def make_request_message(
self, content: str, user: str = "[email protected]", user_name: str = "foo"
) -> Dict[str, str]:
message = dict(sender_email=user, content=content, sender_full_name=user_name)
return message

def test_no_command(self):
message = dict(
content="magic", type="stream", sender_email="[email protected]", sender_full_name="boo"
Expand All @@ -18,19 +26,74 @@ def test_no_command(self):
res["content"], "You are not in a game at the moment. Type `help` for help."
)

def verify_response(
self,
request: str,
expected_response: str,
response_number: int,
user: str = "[email protected]",
) -> None:
"""
This function serves a similar purpose
to BotTestCase.verify_dialog, but allows
for multiple responses to be validated,
and for mocking of the bot's internal data
"""

bot, bot_handler = self._get_handlers()
message = self.make_request_message(request, user)
bot_handler.reset_transcript()

bot.handle_message(message, bot_handler)

responses = [message for (method, message) in bot_handler.transcript]

first_response = responses[response_number]
self.assertEqual(expected_response, first_response["content"])

def help_message(self) -> str:
return """
** Merels Bot Help:**
*Preface all commands with @**test-bot***
* To start a game in a stream (*recommended*), type
`start game`
* To start a game against another player, type
`start game with @<player-name>`
* To play game with the current number of players, type
`play game`
* To quit a game at any time, type
`quit`
* To end a game with a draw, type
`draw`
* To forfeit a game, type
`forfeit`
* To see the leaderboard, type
`leaderboard`
* To withdraw an invitation, type
`cancel game`
* To see rules of this game, type
`rules`
* To make your move during a game, type
```move <column-number>``` or ```<column-number>```
"""




# FIXME: Add tests for computer moves
# FIXME: Add test lib for game_handler

# Test for unchanging aspects within the game
# Player Color, Start Message, Moving Message
def test_static_responses(self) -> None:
model, message_handler = self._get_game_handlers()
self.assertNotEqual(message_handler.get_player_color(0), None)
self.assertNotEqual(message_handler.game_start_message(), None)
self.assertNotEqual(message_handler.get_player_color(0),None)
self.assertNotEqual(message_handler.game_start_message(),None)
self.assertEqual(
message_handler.alert_move_message("foo", "moved right"), "foo :moved right"
message_handler.alert_move_message("foo","moved right"),"foo :moved right"
)


# Test to see if the attributes exist
def test_has_attributes(self) -> None:
model, message_handler = self._get_game_handlers()
Expand Down
Loading