Skip to content

bridge_with_slack: Do not use a stale Zulip client for send_message. #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2024
Merged

bridge_with_slack: Do not use a stale Zulip client for send_message. #819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bebd7d
Slack bridge: Remove unused code.
rht Jan 4, 2024
2227945
bridge_with_slack: Do not use a stale Zulip client for send_message.
rht Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions zulip/integrations/bridge_with_slack/run-slack-bridge
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,19 @@ class SlackBridge:
}

# zulip-specific
self.zulip_client = zulip.Client(
email=self.zulip_config["email"],
api_key=self.zulip_config["api_key"],
site=self.zulip_config["site"],
)
def zulip_client_constructor() -> zulip.Client:
return zulip.Client(
email=self.zulip_config["email"],
api_key=self.zulip_config["api_key"],
site=self.zulip_config["site"],
)

self.zulip_client = zulip_client_constructor()
# Temporary workaround until
# https://github.com/zulip/python-zulip-api/issues/761 is fixed.
self.zulip_client_constructor = zulip_client_constructor

# slack-specific
self.channel = self.slack_config["channel"]
self.slack_client = rtm
# Spawn a non-websocket client for getting the users
# list and for posting messages in Slack.
Expand Down Expand Up @@ -122,7 +127,7 @@ class SlackBridge:
subject=zulip_endpoint["topic"],
content=content,
)
self.zulip_client.send_message(msg_data)
self.zulip_client_constructor().send_message(msg_data)

self.slack_client.start()

Expand Down