Support ancestor authorization on interfaces - #56
Merged
Conversation
zth
marked this pull request as ready for review
August 2, 2026 19:56
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@gql.authorize.byAncestoron interface types and fieldsSafety
The existing path-dominance proof still runs independently for every concrete field. An inherited assertion fails generation if any concrete field is reachable through an unprotected path. The annotation remains compile-time-only and emits no additional runtime policy evaluation.
Tests cover interface type and field defaults, exact manifest provenance, concrete public overrides, transitive interface inheritance, and unsafe-path rejection.
Validation
opam exec --switch=5.3.0 -- make testopam exec --switch=5.3.0 -- make checkformatgit diff --check