-
Notifications
You must be signed in to change notification settings - Fork 73
fix: Safkeyring truststore bug fix in certificate-analyzer #4595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hrishikesh-nalawade
wants to merge
6
commits into
v3.x.x
Choose a base branch
from
hrishikesh-nalawade/GH4592/certificate-analyzer-bug
base: v3.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aab1c45
safkeyring truststore bug fix
hrishikesh-nalawade 8c2bfaf
Merge branch 'v3.x.x' into hrishikesh-nalawade/GH4592/certificate-ana…
hrishikesh-nalawade d203752
safkeyring truststore bug fix
hrishikesh-nalawade b88deba
Merge branch 'v3.x.x' into hrishikesh-nalawade/GH4592/certificate-ana…
pablocarle a8fe984
Merge branch 'v3.x.x' into hrishikesh-nalawade/GH4592/certificate-ana…
pablocarle f62ec91
Merge branch 'v3.x.x' into hrishikesh-nalawade/GH4592/certificate-ana…
balhar-jakub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |
| public class Analyser { | ||
|
|
||
| public static int mainWithExitCode(String[] args) { | ||
| ensureSafkeyringHandler(); | ||
| try { | ||
| ApimlConf conf = new ApimlConf(); | ||
| CommandLine cmd = new CommandLine(conf); | ||
|
|
@@ -62,6 +63,20 @@ public static int mainWithExitCode(String[] args) { | |
| return 4; | ||
| } | ||
|
|
||
| /** | ||
| * Registers the IBM SAF keyring URL protocol handler so that | ||
| * {@code new URL("safkeyring://...")} works on z/OS without requiring the | ||
| * caller to pass {@code -Djava.protocol.handler.pkgs=com.ibm.crypto.provider}. | ||
| * On non-z/OS platforms the handler class is simply not found and is ignored. | ||
| */ | ||
| static void ensureSafkeyringHandler() { | ||
| String existing = System.getProperty("java.protocol.handler.pkgs", ""); | ||
| if (!existing.contains("com.ibm.crypto.provider")) { | ||
| System.setProperty("java.protocol.handler.pkgs", | ||
| existing.isEmpty() ? "com.ibm.crypto.provider" : existing + "|com.ibm.crypto.provider"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Curious if this works with Java 21 too? |
||
| } | ||
| } | ||
|
|
||
| public static final void main(String[] args) { | ||
| System.exit(mainWithExitCode(args)); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the start.sh scripts for API ML components we have
java.protocol.handler.pkgsalways set tocom.ibm.crypto.provider. Should we have it the same way also for the analyser?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have the place to push this in, I would say yes.