Skip to content

Return Limited / Granted on request, instead of always Granted #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlo1
Copy link
Contributor

@jlo1 jlo1 commented Feb 14, 2025

Summary

When requesting Contacts permissions on iOS, we'd return RESULTS.GRANTED even when the user provides LIMITED permissions.

Instead of returning granted based on boolean return, just return the status directly

Test Plan

  • Reset permissions in app xcrun simctl privacy booted reset contacts <APP_ID>
  • Allow limited on first go --> should return limited. Allow full access on first go --> should return granted

What are the steps to test it (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

@jlo1 jlo1 requested a review from zoontek as a code owner February 14, 2025 19:42
@zoontek
Copy link
Owner

zoontek commented Feb 19, 2025

Issue here is that relying on status is flaky: #911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants