Feature/fix/expiry time access token #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex 1 This allows to have an editorconfig with insert_final_new_line and prevents a nasty bug to track down.
Feature/extend array access check
…ing them PHP throws an exception when you call non-static methods from within a static method. This was done until this change.
The sandbox flag comes into the zoho api as boolean flag from our config
file but was interpreted by the official zcrm php sdk as string ("true" or "false")
which makes no sense. Thus, interpet it as boolean value to decide whether to use
sandbox or production.
Interpret sandbox env flag as boolean
Remove array filter to allow syncing of null values
Bugfix Check if is array before calling the count function
…quare ones for PHP 7.4
JOBS-526 Replaces deprecated offset access syntax
…zoho-api Bugfix/jobs 845/zoho crm not call zoho api
The expiry time is returned in seconds from the refresh token call but the current timestamp is retrieved in milliseconds. Thus we have to convert the duration first to milliseconds before adding it to the final expiry time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes