Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add spilt BLE tests #2737

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Dec 31, 2024

In anticipations for some refactors to support other split transports than BLE, add some integration tests to our split BLE code to assure the basics of spits are working.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@petejohanson petejohanson added split bluetooth Bluetooth related items tests labels Dec 31, 2024
@petejohanson petejohanson self-assigned this Dec 31, 2024
@petejohanson petejohanson requested a review from a team as a code owner December 31, 2024 19:24
@petejohanson petejohanson force-pushed the testing/ble-split-tests branch from 65e2492 to 0521893 Compare December 31, 2024 19:39
* Enhance the BLE test runner to build additional peripheral builds
  when detecting peripheral*.overlay files in the test.
* Add basic and multiple-peripheral tests to exercise the testing
  support
* Properly exclude storing peripheral addresses to settings when
  settings support isn't turned on.
@petejohanson petejohanson force-pushed the testing/ble-split-tests branch 2 times, most recently from 58e6f2e to 24cae9d Compare January 1, 2025 21:32
Add test for triggering local behaviors on split peripherals.
@petejohanson petejohanson force-pushed the testing/ble-split-tests branch from 24cae9d to 4b079b9 Compare January 1, 2025 21:40
@petejohanson petejohanson merged commit 85aba16 into zmkfirmware:main Jan 1, 2025
48 checks passed
caksoylar pushed a commit to caksoylar/zmk that referenced this pull request Jan 11, 2025
* Enhance the BLE test runner to build additional peripheral builds
  when detecting peripheral*.overlay files in the test.
* Add basic and multiple-peripheral tests to exercise the testing
  support
* Add test for triggering local behaviors on split peripherals.

fix(ble): Fix building split code w/o settings

* Properly exclude storing peripheral addresses to settings when
  settings support isn't turned on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluetooth Bluetooth related items split tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant