Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs) Adds a feature page about dongles #2401
feat(docs) Adds a feature page about dongles #2401
Changes from 21 commits
e5c19a1
89d47f1
8c95330
26f3c7c
f5ff4e3
8ca4971
6e622eb
877d654
997fc9f
439c045
21bb47d
afe4002
cf74b62
4da4704
c791f9f
d3e821e
a27a553
9a94cc7
e85a34b
7fea1a7
aa89b74
61b0203
f06f261
d72ae98
c64642f
900ff1f
83e6241
344936e
0eb3770
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a product liability perspective, I'd say "in some situations, ..." as poor Bluetooth connectivity can push latency even higher. Is it worth calling out one of the more common scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this [power increase] is optional and unrelated to using a dongle. I agree it may be helpful and perhaps merits a text reference to documentation of
BT_CTLR_TX_PWR_PLUS_8
such as https://zmk.dev/docs/troubleshooting/connection-issuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the common shield configuration is imported and different boards are used for the dongle than for the shields, then this can lead to problems if board-specific aliases (e.g.
&pro_micro
,&xiao_d
) are used.I therefore had to delete unused nodes with these aliases (e.g.
/delete-node/ &kscan0;
), but perhaps there is a nicer solution.