feat(boards): add encoder support to planck #2155
Conversation
| a-gpios = <&gpiob 12 GPIO_PULL_UP>; | ||
| b-gpios = <&gpiob 13 GPIO_PULL_UP>; | ||
| steps = <80>; | ||
| status = "okay"; |
There was a problem hiding this comment.
There did not appear to be a clear precedent for setting the status of an encoder on a unibody board. Most boards set this to "disabled" in the dts and then set the respective encoder statuses to "okay" in the overlays for each half. Let me know if there is a better way to handle this.
There was a problem hiding this comment.
Ideally you'd have it disabled, with a commented out section in the keymap to enable the encoder node if you're using it.
There was a problem hiding this comment.
Ideally you'd have it disabled, with a commented out section in the keymap to enable the encoder node if you're using it.
Cool. Will do.
There was a problem hiding this comment.
Encoder is now disabled by default with commented-out node in keymap to enable it.
SethMilliken
force-pushed
the
seth/planck-encoder-support
branch
from
5a5aace to
e0cfabf
Compare
| @@ -44,6 +44,20 @@ | |||
| ; | |||
| }; | |||
|
|
|||
| left_encoder: left_encoder { | |||
There was a problem hiding this comment.
If the keyboard only supports one encoder, should we just call it "encoder"?
There was a problem hiding this comment.
I had gone with that originally, but rev7 supports two encoders, one on each side. If we eventually support that, it seems like this would be a better fit if they share config. I can switch it back if you like though.
There was a problem hiding this comment.
Whenever we do that, we can do that in a new planck_rev7.dts, etc. For now, keep this relevant to the rev6, so I'd suggest renaming back to just encoder.
There was a problem hiding this comment.
Aye, aye. Renamed to encoder.
SethMilliken
force-pushed
the
seth/planck-encoder-support
branch
from
e0cfabf to
4b89c04
Compare
This adds support for an optional rotary encoder in the leftmost column of the Planck rev6. All positions for the encoder map to the same pins on the board, so this ought to work regardless of which position is chosen.
I have been using this regularly for the last week without any issues. FWIW, my encoder is in the bottom row.