Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(improve-modal): modal-dialog #117

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pongstr
Copy link
Contributor

@pongstr pongstr commented Dec 24, 2024

  • feat: improve modal transition on open/close event
    • added: modal stories
  • feat: generic zmk-logo for use on modals (or anywhere in the app)
  • updated: migrated sections that utilizes GenericModal
    • moved: useModalRef -> @/components/modal/useModalRef
    • removed: GenericModal

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for zmk-studio ready!

Name Link
🔨 Latest commit b669399
🔍 Latest deploy log https://app.netlify.com/sites/zmk-studio/deploys/6777960885440e0008cc3413
😎 Deploy Preview https://deploy-preview-117.preview.zmk.studio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pongstr pongstr force-pushed the improve-generic-modal branch 3 times, most recently from 8138eb7 to 993b59a Compare December 24, 2024 14:40
@pongstr pongstr changed the title chore(modal): modal-dialog chore(improve-modal): modal-dialog Dec 24, 2024
@pongstr pongstr marked this pull request as ready for review December 24, 2024 15:36
@pongstr pongstr marked this pull request as draft December 25, 2024 09:50
@pongstr pongstr force-pushed the improve-generic-modal branch 3 times, most recently from 3005927 to 18e2e53 Compare December 25, 2024 11:21
- feat: improve modal transitions on open/close
- docs: modal dialog stories+docs
@pongstr pongstr force-pushed the improve-generic-modal branch from 18e2e53 to 0c304ce Compare December 25, 2024 11:42
@pongstr pongstr force-pushed the improve-generic-modal branch from 0d4323e to f16dee5 Compare December 25, 2024 14:50
@pongstr pongstr force-pushed the improve-generic-modal branch from f16dee5 to ba2f551 Compare December 25, 2024 14:55
@pongstr pongstr marked this pull request as ready for review December 25, 2024 14:58
@pongstr pongstr force-pushed the improve-generic-modal branch from fc6e5c9 to b669399 Compare January 3, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant