Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow up on database certificates properties renaming #284

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

yann-soubeyrand
Copy link
Contributor

Hi,

It seems that the renaming of the database certificates properties broke the creation of the secret when certificates are provided to the charts. This PR is my attempt to fix it.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@yann-soubeyrand yann-soubeyrand force-pushed the fix-db-ssl-ca-crt branch 2 times, most recently from 161a43d to 981eee8 Compare December 12, 2024 09:57
@eliobischof eliobischof self-requested a review December 14, 2024 17:10
@eliobischof eliobischof self-assigned this Dec 17, 2024
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @yann-soubeyrand, LGTM 🚀

If you'd like us to send you a small gift in return, please shoot us a message to [email protected]

@eliobischof eliobischof enabled auto-merge (squash) February 4, 2025 12:07
@eliobischof
Copy link
Member

@yann-soubeyrand please merge the base branch back into the PRs branch or allow us to commit changes to your branch

auto-merge was automatically disabled February 4, 2025 13:54

Head branch was pushed to by a user without write access

@yann-soubeyrand
Copy link
Contributor Author

@eliobischof done! I cannot see the “Allow edits from maintainers checkbox”, is it something that has to be activated in the repository settings first?

@eliobischof eliobischof merged commit e4fce6f into zitadel:main Feb 4, 2025
9 checks passed
@eliobischof
Copy link
Member

@eliobischof done! I cannot see the “Allow edits from maintainers checkbox”, is it something that has to be activated in the repository settings first?

🤷‍♂️ idk, but I could merge now.
Thank you.

@yann-soubeyrand yann-soubeyrand deleted the fix-db-ssl-ca-crt branch February 4, 2025 15:39
@yann-soubeyrand
Copy link
Contributor Author

Thanks @eliobischof! As for the gift, if you can fix these issues I would be more than grateful 😊

zitadel/zitadel#9141
zitadel/zitadel#9200

@eliobischof
Copy link
Member

Thanks @eliobischof! As for the gift, if you can fix these issues I would be more than grateful 😊

zitadel/zitadel#9141
zitadel/zitadel#9200

I raised #9141 internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants