Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to insert additional labels to the pod #172

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feat: add option to insert additional labels to the pod #172

merged 3 commits into from
Feb 21, 2024

Conversation

mdarii
Copy link
Contributor

@mdarii mdarii commented Feb 19, 2024 •
edited
Loading

Definition of Ready

Some k8s operators require custom labels to be added to the pod.

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Feb 19, 2024
@mdarii mdarii mentioned this pull request Feb 19, 2024
Closed
2 tasks
@hifabienne hifabienne linked an issue Feb 19, 2024 that may be closed by this pull request
Add option to add custom labels to the k8s pod #173
Closed
2 tasks
@eliobischof eliobischof changed the title Add option to insert additional labels to the pod feat: add option to insert additional labels to the pod Feb 21, 2024
eliobischof
eliobischof approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM 👍
I just bumped the minor instead of the patch version.

@eliobischof eliobischof enabled auto-merge (squash) February 21, 2024 08:00
@eliobischof eliobischof merged commit d80cb7b into zitadel:main Feb 21, 2024
9 checks passed
@bjw-s bjw-s mentioned this pull request Mar 21, 2024
Merged
11 tasks
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
@mdarii @eliobischof
feat: add option to insert additional labels to the pod (zitadel#172)
d781b91 
* Add option to insert additional labels to the pod

* increased chart version

* bump minor

---------

Co-authored-by: Elio Bischof <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
devops os-contribution This is a contribution from our open-source community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to add custom labels to the k8s pod
3 participants
@mdarii @eliobischof @hifabienne