Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi-chart deployment #162

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

thomaspetit
Copy link
Contributor

@thomaspetit thomaspetit commented Jan 12, 2024

Description

All information is referenced in #161

As I would like to already incrementally fix this setup and ensure that Zitadel can easily be deployed the current proposal is to move these annotations:

helm.sh/hook: pre-install,pre-upgrade
helm.sh/hook-delete-policy: before-hook-creation
helm.sh/hook-weight: "1"

.. to the values.yaml as was basically already done for some resources already like the initJob values.yaml#134

Goal for the initial PR is to make a non-breaking change on the chart

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@thomaspetit
Copy link
Contributor Author

@arnouthoebreckx as we've been discussing this offline, feel free to comment too 🚀

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Jan 15, 2024
@hifabienne hifabienne linked an issue Jan 15, 2024 that may be closed by this pull request
2 tasks
@hifabienne hifabienne requested a review from stebenz January 24, 2024 10:23
@eliobischof
Copy link
Member

hey @thomaspetit thanks for this very useful feature! Please have a look at the small suggestion above.

If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.

@thomaspetit
Copy link
Contributor Author

thomaspetit commented Jan 26, 2024

hey @thomaspetit thanks for this very useful feature! Please have a look at the small suggestion above.

If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.

I had a good reason to not put it in the values as appararntly dbSslRootCrt has been deprecated when the switch to v5 happened on Zitadel:

| `zitadel.dbSslRootCrt` | `zitadel.dbSslCaCrt` |

If I would move it back to the values.yaml it would mean that we re-introduce a dbSslRootCrt (which was removed): https://github.com/zitadel/zitadel-charts/blob/zitadel-5.0.0/charts/zitadel/values.yaml#L57 (ref to old code)

Let me know if you still want it in there and I'll do the necessary work 😁 @eliobischof

@eliobischof
Copy link
Member

hey @thomaspetit thanks for this very useful feature! Please have a look at the small suggestion above.

If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.

I had a good reason to not put it in the values as appararntly dbSslRootCrt has been deprecated when the switch to v5 happened on Zitadel:

| `zitadel.dbSslRootCrt` | `zitadel.dbSslCaCrt` |

If I would move it back to the values.yaml it would mean that we re-introduce a dbSslRootCrt (which was removed): https://github.com/zitadel/zitadel-charts/blob/zitadel-5.0.0/charts/zitadel/values.yaml#L57 (ref to old code)

Let me know if you still want it in there and I'll do the necessary work 😁 @eliobischof

Makes perfect sense 😃

@eliobischof eliobischof changed the title Support multi-chart deployment feat: support multi-chart deployment Jan 26, 2024
@eliobischof eliobischof enabled auto-merge (squash) January 26, 2024 13:57
@eliobischof eliobischof merged commit e947785 into zitadel:main Jan 26, 2024
9 checks passed
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* Support multi-chart deployment

* Fix dangling annotations

* increment major

---------

Co-authored-by: Elio Bischof <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow default annotations to be overriden in a clean way
3 participants