-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multi-chart deployment #162
Conversation
@arnouthoebreckx as we've been discussing this offline, feel free to comment too 🚀 |
hey @thomaspetit thanks for this very useful feature! Please have a look at the small suggestion above. If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size. |
I had a good reason to not put it in the values as appararntly dbSslRootCrt has been deprecated when the switch to v5 happened on Zitadel: Line 52 in d4d9977
If I would move it back to the values.yaml it would mean that we re-introduce a dbSslRootCrt (which was removed): https://github.com/zitadel/zitadel-charts/blob/zitadel-5.0.0/charts/zitadel/values.yaml#L57 (ref to old code) Let me know if you still want it in there and I'll do the necessary work 😁 @eliobischof |
Makes perfect sense 😃 |
* Support multi-chart deployment * Fix dangling annotations * increment major --------- Co-authored-by: Elio Bischof <[email protected]>
Description
All information is referenced in #161
As I would like to already incrementally fix this setup and ensure that Zitadel can easily be deployed the current proposal is to move these annotations:
.. to the
values.yaml
as was basically already done for some resources already like theinitJob
values.yaml#134Goal for the initial PR is to make a non-breaking change on the chart
Definition of Ready