Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update default zitadel version to v2.46.0 with init projections #160

Merged
merged 11 commits into from
Feb 21, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Jan 12, 2024

This Commit adds the ability to specify additional arguments to pass to the setup job besides the preconfigured ones. By default, --init-projections=true is passed. This ensures that the setup job properly migrates the database between versions.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof self-assigned this Jan 12, 2024
@eliobischof eliobischof requested a review from stebenz January 12, 2024 17:32
@eliobischof eliobischof changed the title feat: update default zitadel feat: update default zitadel version to v2.43.4 Jan 12, 2024
meyfa and others added 2 commits February 5, 2024 10:57
Closes #168. This patch adds the ability to specify additional arguments
to pass to the setup job besides the preconfigured ones. By default,
`--init-projections=true` is passed. This ensures that the setup job
properly migrates the database between versions.
@meyfa
Copy link
Contributor

meyfa commented Feb 5, 2024

Nit: I think the PR title could be updated to reflect the updated version :)

@eliobischof eliobischof changed the title feat: update default zitadel version to v2.43.4 feat: update default zitadel version to v2.44.1 Feb 5, 2024
@meyfa
Copy link
Contributor

meyfa commented Feb 12, 2024

Is there an expected timeline for merging this PR? There have been further Zitadel releases, and I would feel much safer updating if #170 was released, but it depends on this PR.

@eliobischof eliobischof changed the title feat: update default zitadel version to v2.44.1 feat: update default zitadel version to v2.45.0 with init projections Feb 15, 2024
@eliobischof
Copy link
Member Author

Is there an expected timeline for merging this PR? There have been further Zitadel releases, and I would feel much safer updating if #170 was released, but it depends on this PR.

I merged #170 because I think these changes should be released together.

@eliobischof
Copy link
Member Author

@stebenz can you review this, plz?

@eliobischof eliobischof changed the title feat: update default zitadel version to v2.45.0 with init projections feat: update default zitadel version to v2.46.0 with init projections Feb 21, 2024
@eliobischof
Copy link
Member Author

@stebenz can you review, plz?

@eliobischof eliobischof merged commit bcfdd4f into main Feb 21, 2024
9 checks passed
@eliobischof eliobischof deleted the update-zitadel branch February 21, 2024 18:46
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
…zitadel#160)

* feat: update default zitadel

* feat: add setupJob additionalArgs, default to `--init-projections=true`

Closes zitadel#168. This patch adds the ability to specify additional arguments
to pass to the setup job besides the preconfigured ones. By default,
`--init-projections=true` is passed. This ensures that the setup job
properly migrates the database between versions.

* fix tests

* increase timeout

* update test dependencies

* setup go

* update zitadel

---------

Co-authored-by: Fabian Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --init-projections=true to setup job
3 participants