Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cockroach helm install without wait #155

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

raunodepasquale
Copy link
Contributor

Do not use the "--wait" option because the init is done by a post-install hook and without the init done the PODs will not start, so you would find yourself locked inside an infinite loop (db pods not working because of missing init and init job not starting because of db pods not working)

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

Do not use the "--wait" option because the init is done by a post-install hook and without the init done the PODs will not start, so you would find yourself locked inside an infinite loop (db pods not working because of missing init and init job not starting because of db pods not working)
@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Dec 29, 2023
@hifabienne hifabienne requested a review from eliobischof January 8, 2024 10:33
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @raunodepasquale thanks for the fix. I just changed the explanations a bit.

If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.

@eliobischof eliobischof changed the title cockroach helm install without wait docs: cockroach helm install without wait Jan 11, 2024
@eliobischof eliobischof merged commit 3caaa1c into zitadel:main Jan 11, 2024
9 checks passed
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* cockroach helm install without wait

Do not use the "--wait" option because the init is done by a post-install hook and without the init done the PODs will not start, so you would find yourself locked inside an infinite loop (db pods not working because of missing init and init job not starting because of db pods not working)

* improve readability

* improve readability

* consistent naming

---------

Co-authored-by: Elio Bischof <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants