Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of some tests for uncovered modules. #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Addition of some tests for uncovered modules. #53

wants to merge 3 commits into from

Conversation

jpd-de
Copy link
Contributor

@jpd-de jpd-de commented Feb 5, 2025

Added integration tests for:

  • Different shapes
  • Vector fields

Added unit tests for all meshes

Additions to existing tests:

  • Expanded unit tests for static Particles and Vector fields
  • Expanded rotation matrices test for zero rotation case

Changed Error-Handling in particle.py and vector_field.py

  • Existing Value Error exception was changed into Index error or ValueError. Please take a look at this.

Small additions to visualizer.py

  • Added a check for the minimum frame number for vector_fields as it already exisits for particles
  • Made sure the output folder exists, if not it will be created. Linked this to the renderer

jpd-de and others added 3 commits December 10, 2024 12:40
@jpd-de
Added lot of unit and integration tests
ed62b54 
New Integration tests:
	- Different shapes
	- Simple Vector Field (static and dynamic)

New unit tests:
	- tests for all meshes
	- Test for static and non static particles and vector fields

Left comments where I wasn't sure, if my changes are valid
@jpd-de
Create .gitkeep
2c4cdad
@jpd-de
Added mesh for test for custom mesh
602a38c
SamTov
SamTov approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@SamTov SamTov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic, thanks for all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamTov SamTov SamTov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpd-de @SamTov