Skip to content

add tests & benchmarks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
userzimmermann merged 1 commit into from
Sep 27, 2025
Merged

add tests & benchmarks #2

userzimmermann merged 1 commit into from
Sep 27, 2025

Conversation

@userzimmermann
Copy link
Member

@userzimmermann userzimmermann commented Sep 26, 2025 •
edited
Loading

Closes #1

@userzimmermann userzimmermann self-assigned this Sep 26, 2025
@userzimmermann userzimmermann added the enhancement New feature or request label Sep 26, 2025
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

Benchmark Results

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark Results

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
            │ current-bench.txt │
            │      sec/op       │
NilPtr-4            2.021n ± 0%
NotNilPtr-4         2.021n ± 3%
geomean             2.021n

            │ current-bench.txt │
            │       B/op        │
NilPtr-4           0.000 ± 0%
NotNilPtr-4        0.000 ± 0%
geomean                       ¹
¹ summaries must be >0 to compute geomean

            │ current-bench.txt │
            │     allocs/op     │
NilPtr-4           0.000 ± 0%
NotNilPtr-4        0.000 ± 0%
geomean                       ¹
¹ summaries must be >0 to compute geomean

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: AMD EPYC 7763 64-Core Processor                
            │ head-bench.txt │
            │     sec/op     │
NilPtr-4         2.181n ± 1%
NotNilPtr-4      2.492n ± 3%
geomean          2.331n

            │ head-bench.txt │
            │      B/op      │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

            │ head-bench.txt │
            │   allocs/op    │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

@userzimmermann userzimmermann force-pushed the zimmermann/testing branch 2 times, most recently from b13a4fe to 31c9fa4 Compare September 27, 2025 16:49
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: AMD EPYC 7763 64-Core Processor                
            │ head-bench.txt │
            │     sec/op     │
NilPtr-4         2.182n ± 4%
NotNilPtr-4      2.492n ± 1%
geomean          2.332n

            │ head-bench.txt │
            │      B/op      │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

            │ head-bench.txt │
            │   allocs/op    │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

@userzimmermann userzimmermann enabled auto-merge (rebase) September 27, 2025 19:08
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: AMD EPYC 7763 64-Core Processor                
            │ head-bench.txt │
            │     sec/op     │
NilPtr-4         2.181n ± 1%
NotNilPtr-4      2.494n ± 2%
geomean          2.332n

            │ head-bench.txt │
            │      B/op      │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

            │ head-bench.txt │
            │   allocs/op    │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: AMD EPYC 7763 64-Core Processor                
            │ head-bench.txt │
            │     sec/op     │
NilPtr-4         2.184n ± 4%
NotNilPtr-4      2.492n ± 0%
geomean          2.333n

            │ head-bench.txt │
            │      B/op      │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

            │ head-bench.txt │
            │   allocs/op    │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

@userzimmermann userzimmermann enabled auto-merge (rebase) September 27, 2025 19:39
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: AMD EPYC 7763 64-Core Processor                
            │ head-bench.txt │
            │     sec/op     │
NilPtr-4         2.181n ± 6%
NotNilPtr-4      2.492n ± 1%
geomean          2.331n

            │ head-bench.txt │
            │      B/op      │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

            │ head-bench.txt │
            │   allocs/op    │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

@userzimmermann userzimmermann enabled auto-merge (squash) September 27, 2025 19:59
@userzimmermann
test: add pointer_test.go
111a6fb 
* Added tests and benchmarks for funcs NilPtr() & NotNilPtr()
* Changed lefthook.yml to run golangci-lint over all files.
* Added .github/workflows/testing.yml w/ jobs test & benchmark.

Closes #1
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Benchmark comparison w/ base branch

goos: linux
goarch: amd64
pkg: github.com/zimmermanncode/go-require
cpu: AMD EPYC 7763 64-Core Processor                
            │ head-bench.txt │
            │     sec/op     │
NilPtr-4         2.180n ± 1%
NotNilPtr-4      2.492n ± 0%
geomean          2.331n

            │ head-bench.txt │
            │      B/op      │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

            │ head-bench.txt │
            │   allocs/op    │
NilPtr-4        0.000 ± 0%
NotNilPtr-4     0.000 ± 0%
geomean                    ¹
¹ summaries must be >0 to compute geomean

@userzimmermann userzimmermann merged commit 71a4d90 into main Sep 27, 2025
6 checks passed
@userzimmermann userzimmermann deleted the zimmermann/testing branch September 27, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimmermannmobile zimmermannmobile zimmermannmobile approved these changes

Assignees

@userzimmermann userzimmermann

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests & benchmarks

3 participants

@userzimmermann @zimmermannmobile