add int filter #545
Merged
add int filter #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwayslove2013
requested changes
Jun 17, 2025
vectordb_bench/backend/cases.py
Outdated
| @@ -52,6 +52,8 @@ class CaseType(Enum): | |||
|
|
|||
| StreamingPerformanceCase = 200 | |||
|
|
|||
| NewIntFilterPerformanceCase = 250 | |||
There was a problem hiding this comment.
use 400 would be better
| @@ -164,6 +165,7 @@ class Cohere(BaseDataset): | |||
| } | |||
| with_scalar_labels: bool = True | |||
| scalar_label_percentages: list[float] = [0.001, 0.002, 0.005, 0.01, 0.02, 0.05, 0.1, 0.2, 0.5] | |||
| scalar_int_rates: list[float] = [0.01, 0.99] | |||
|
|
|||
| f"Results will show index building time, recall, and maximum QPS." | ||
| ), | ||
| cases=generate_int_filter_cases(dataset_with_size_type), | ||
| ) |
Caroline-an777
force-pushed
the
main
branch
4 times, most recently
from
d49b296 to
9178cde
Compare
alwayslove2013
approved these changes
Jul 24, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, Caroline-an777 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
akhilpathivada
pushed a commit
to akhilpathivada/VectorDBBench
that referenced
this pull request
Jul 24, 2025
- add new int filter to run tests with multiple filter rate values like[0.001,0.02,0.3,...,0.7,0.98,0.999] instead of just 0.01 and 0.99 - achieve compatibility for int filter case between new and old versions - add int filter performance page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.add new int filter to run tests with multiple filter rate values like[0.001,0.02,0.3,...,0.7,0.98,0.999] instead of just 0.01 and 0.99
2.achieve compatibility for int filter case between new and old versions
3.add int filter performance page