Skip to content

refactor path traversal when searching for build.zig files #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techatrix merged 1 commit into from
May 18, 2026
Merged

refactor path traversal when searching for build.zig files #3203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/DocumentStore.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,20 +1441,18 @@ fn collectPotentialBuildFiles(self: *DocumentStore, uri: Uri) error{ Canceled, O
};
defer self.allocator.free(path);

// Zig's filesystem API does not handle `OBJECT_PATH_INVALID` being returned when dealing with invalid UNC paths on Windows.
// https://github.com/ziglang/zig/issues/15607
const root_end_index: usize = root_end_index: {
if (builtin.target.os.tag != .windows) break :root_end_index 0;
const component_iterator = std.Io.Dir.path.componentIterator(path);
break :root_end_index component_iterator.root_end_index;
};

var current_path: []const u8 = path;
while (std.Io.Dir.path.dirname(current_path)) |potential_root_path| : (current_path = potential_root_path) {
if (potential_root_path.len < root_end_index) break;
if (!try buildDotZigExists(self.io, potential_root_path)) continue;

const build_path = try std.Io.Dir.path.join(self.allocator, &.{ potential_root_path, "build.zig" });
var it = std.Io.Dir.path.componentIterator(path);
_ = it.last();
var did_check_root = false;
while (true) {
const dir_path = if (it.previous()) |comp| comp.path else blk: {
if (did_check_root) break :blk null;
did_check_root = true;
break :blk it.root();
} orelse break;
if (!try buildDotZigExists(self.io, dir_path)) continue;

const build_path = try std.Io.Dir.path.join(self.allocator, &.{ dir_path, "build.zig" });
defer self.allocator.free(build_path);

try potential_build_files.ensureUnusedCapacity(self.allocator, 1);
Expand Down
Loading