add config option insert_completion #2226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at filtering is left to the client
|
Looks good. |
GreyElaina
reviewed
Mar 22, 2025
| .{ .InsertReplaceEdit = .{ .newText = item.insertText orelse item.label, .insert = insert_range, .replace = replace_range } } | ||
| else | ||
| .{ .TextEdit = .{ .newText = item.insertText orelse item.label, .range = insert_range } }; | ||
| switch (builder.server.config.insert_completions) { |
|
This workaround should not be necessary with 5449f65. Let me know if it resolves your issue. If not, please provide a reproducible example that showcases the observed issue. |
|
yeah that solution seems better to me, should work. |
|
No response from OP so I am going to assume that this issue has been resolved by 5449f65. If the issue is still present, please open a new issue with a reproducible example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to use insertText completionitems instead of textEdit completionitems implying that filtering needs to be done on the client. This is probably a niche fix as most editors filter regardless, of which which completion kind is received. NeoVim declared this behavior as intentional so this pr represents a workaround, until zls filters auto completions on its own