Skip to content

Don't hide handler exceptions behind debug #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
+3 −3
Draft

Don't hide handler exceptions behind debug #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b6e91
Don't hide handler exceptions behind debug
elupus Jul 26, 2024
f9279cd
Adjust test
elupus Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_cluster_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,8 +847,8 @@ async def test_ep_cluster_handlers_configure(cluster_handler) -> None:
assert ch.async_configure.call_count == 1
assert ch.async_configure.await_count == 1

assert ch_3.debug.call_count == 2
assert ch_5.debug.call_count == 2
assert ch_3.warning.call_count == 2
assert ch_5.warning.call_count == 2


async def test_poll_control_configure(
Expand Down
2 changes: 1 addition & 1 deletion zha/zigbee/endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ async def _execute_handler_tasks(
results = await gather(*tasks, return_exceptions=True)
for cluster_handler, outcome in zip(cluster_handlers, results):
if isinstance(outcome, Exception):
cluster_handler.debug(
cluster_handler.warning(
"'%s' stage failed: %s", func_name, str(outcome), exc_info=outcome
)
else:
Expand Down
Loading